Control: tags -1 confirmed
Control: severity -1 serious

Hi Frédéric,

On 11-07-2021 01:33, Frédéric Brière wrote:
> liferea 1.13.5 will immediately segfault when selecting a news bin in
> the left pane.  (And if a news bin was the last selected item before
> upgrading, it will then automatically crash on startup.  I'd argue this
> would justify a bump to serious; you be the judge.)

Don't be shy ;), done so now.

> The bug is in feed_add_xml_attributes(), where node->subscription gets
> dereferenced at the end, even if it was found to be NULL beforehand.
> 
> This was fixed upstream in 49cf235, by moving the last three lines
> inside the if(), where they belong.  That patch does not apply cleanly
> to 1.13.5 (due to 9db267f), so I'm attaching a revised version.

Thanks for the report, and the patch, will upload soon.

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

Reply via email to