Source: xymon Version: 4.3.30-1 Severity: normal Dear Maintainer,
I noticed, that in Xymon 4.3.28 as well as in 4.3.30 opening the "Snapshot Report" (snapshot.sh) as well as the "Availability Report" (report.sh) in the "Reports" menu do not work as expected, but try to download a file snapshot.sh or report.sh. Digging deeper into this, I noticed, that this seems a Firefox (currently I use 89.0.2) only problem, while chromium works without problems. In the code web/snapshot.c and web/report.c I found a variable usemultipart, which is 1 by default and is reset to 0 if HTTP_USER_AGENT contains "KHTML", which (according a comment) cannot handle multipart documents. It seems, that current Firefox also can not handle this correct, while Chromium uses the User-Agent "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36"# so it already disables multipart. From my point of view, it may be a good idea to disable usemultipart by default, if Safari, Konqueror and Chrom(ium) disable it via the KHTML in the User-Agent and Firefox doesn't work with usemultipart=0. A patch against 4.3.28-5+deb10u1 is attached, which solves the problems for me using Firefox, it should also wirk with 4.3.30. Greetings Roland
--- a/web/report.c +++ b/web/report.c @@ -201,7 +201,7 @@ int main(int argc, char *argv[]) int argi, newargi; char *envarea = NULL; char *useragent = NULL; - int usemultipart = 1; + int usemultipart = 0; newargi = 0; xymongen_argv[newargi++] = xymongencmd; --- a/web/snapshot.c +++ b/web/snapshot.c @@ -145,7 +145,7 @@ int main(int argc, char *argv[]) int argi, newargi; char *envarea = NULL; char *useragent; - int usemultipart = 1; + int usemultipart = 0; newargi = 0; xymongen_argv[newargi++] = xymongencmd;
signature.asc
Description: PGP signature
