Hi,

Am Montag, den 21.06.2021, 11:12 +0200 schrieb Chris Hofstaedtler:
> Package: vip-manager
> Version: 1.0.1-3+b2
> Severity: serious
> 
> Dear Maintainer,
> 
> thanks for maintaining the vip-manager package.
> 
> I've noticed that the service file
> /lib/systemd/system/vip-manager.service uses options with one dash
> (ex: `-ip=a.b.c.d`), but the vip-manager binary expects two dashes
> (`--ip=a.b.c.d`).
> 
> I believe old vip-manager versions used one dash, but apparently
> this has changed, and the Debian patch "service_file.patch" needs to
> be updated.

You're right. I only tested the Debian-integrated version of vip-manager 
where one uses the templated service unit that's corresponding to the
Patroni service/Debian PostgreSQL cluster (e.g. vip-manager@13-main) and
not the general one.

> Setting severity serious, because the default service file appears
> broken.

I've pushed a fix now according to your other mail. I first thought of
harmonizing the two service units some more (and just use environment
variables), but then decided to go for the minimal fix for bullseye.
I'll try to overhaul this for bookworm.

I also uploaded a new package candidate to
https://people.debian.org/~mbanck/.tmp/vip-manager_1.0.1-4_amd64.deb
if you want to test it. Or just build it yourself from the salsa repo.


Michael

-- 
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
E-Mail: michael.ba...@credativ.de

credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Sascha Heuer, Geoff Richardson, Peter 
Lilley

Unser Umgang mit personenbezogenen Daten unterliegt
folgenden Bestimmungen: https://www.credativ.de/datenschutz

Reply via email to