Control: affects -1 =
Control: reassign -1 src:iagno
Control: severity -1 normal
Control: tags -1 + patch upstream
On Tue, Aug 31, 2021 at 04:50:04PM +0200, Helmut Grohne wrote:
> Three days ago, iagno cross built successfully. Now it fails. A notable
> difference is the version of meson, which was upped from 0.56.2 to
> 0.59.1. You can find the successful build at:
>
> http://crossqa.debian.net/build/iagno_1:3.38.1-2_armel_20210827165555.log
>
> Now the failing build log is:
>
> http://crossqa.subdivi.de/build/iagno_1:3.38.1-2_s390x_20210831122104.log
>
> A very notable difference is the following output included in the
> failure and missing in the successful one:
>
> | ERROR: An exe_wrapper is needed but was not found. Please define one in
> cross file and check the command and/or add it to PATH.
> |
> | A full log can be found at
> /<<PKGBUILDDIR>>/obj-s390x-linux-gnu/meson-logs/meson-log.txt
> | cd obj-s390x-linux-gnu && tail -v -n \+0 meson-logs/meson-log.txt
>
> Since iagno didn't need an exe_wrapper earlier it seems dubious to need
> one now. That strongly suggests this to be a meson regression.
>
> I expect that this affects multiple packages and therefore apply a
> higher severity than normal.
The expectation turned out to be wrong. @xclaesse found the cause in
iagno's src/meson.build where a run_target is contained, which isn't run
by default. meson got stricter in its error reporting, so the target
should be made conditional to meson.can_run_host_binaries(). Please
consider applying the attached patch and credit @xclaesse instead of me.
Helmut
--- iagno-3.38.1.orig/src/meson.build
+++ iagno-3.38.1/src/meson.build
@@ -1,25 +1,27 @@
-# Tests generation
-run_target('update-perfs-tests', command: executable ('iagno-perfs-tests-generator',
- [
- 'vapi/config.vapi',
- 'perfs-tests-generator.vala',
- 'computer-player.vala',
- 'computer-reversi.vala',
- 'game.vala',
- 'player.vala'
- ],
- c_args: [
- '-include', 'config.h'
- ],
- vala_args: [
- '--enable-experimental-non-null'
- ],
- dependencies : [
- gio_dependency,
- posix_dependency
- ]
+if meson.can_run_host_binaries()
+ # Tests generation
+ run_target('update-perfs-tests', command: executable ('iagno-perfs-tests-generator',
+ [
+ 'vapi/config.vapi',
+ 'perfs-tests-generator.vala',
+ 'computer-player.vala',
+ 'computer-reversi.vala',
+ 'game.vala',
+ 'player.vala'
+ ],
+ c_args: [
+ '-include', 'config.h'
+ ],
+ vala_args: [
+ '--enable-experimental-non-null'
+ ],
+ dependencies : [
+ gio_dependency,
+ posix_dependency
+ ]
+ )
)
-)
+endif
# Generated tests
if get_option('perfs_tests')
