Em qua., 8 de set. de 2021 às 07:53, Sebastian Ramacher
<sramac...@debian.org> escreveu:
>
> Control: tags -1 wontfix
>
> On 2021-09-06 23:24:48 -0300, Eriberto Mota wrote:
> > Em seg., 6 de set. de 2021 às 12:41, Sebastian Ramacher
> > <sramac...@debian.org> escreveu:
> > >
> > > Control: tags -1 moreinfo
> > >
> > > On 2021-09-06 12:10:20 -0300, Joao Eriberto Mota Filho wrote:
> > > > Package: obs-plugins
> > > > Version: 27.0.1+dfsg1-1
> > > > Severity: wishlist
> > > >
> > > > Dear maintainer,
> > > >
> > > > Since OBS-27, move-transition[1] is supported. This very useful plugin 
> > > > needs to
> > > > be built with OBS (not independent).
> > >
> > > Any why can't it be built with libobs-dev? This should contain all
> > > headers that are required to build an OBS plugin.
> >
> > Thanks for your quick reply.
> >
> > I tried to build move-transition yesterday. However, the cmake failed
> > in several ways. I know autotools very well, but I don't know cmake.
> > Also, the upstream put in README to build inside of OBS. After some
> > work and several changes in CMakeLists.txt, now I have already
> > packaged move-transition using libobs-dev and I am sorry for my
> > mistake. However, I have two problems and I need help.
> >
> > 1. move-transition needs plugins/obs-transitions/easings.h from OBS.
> > Could you provide this file to avoid a copy from obs-studio?
>
> Ah, now I understand. I don't think it helps if other plugins depend on
> obs' internal headers that may change without notice. I think the best
> way forward would be to get the move-transition plugin merged upstream.
> So this will be a wontfix from my side, sorry.


I thought as a solution that If you provide
plugins/obs-transitions/easings.h in a -dev, I could use it and
schedule semanal tests in Salsa (CI) to warn if the move-transition
stops building. If not provided from a -dev, I will embed
plugins/obs-transitions/easings.h via packaging.


> > 2. I think I found a mistake in libobs-dev. All headers are in
> > /usr/include/obs/, however the /usr/include/obs/obs-frontend-api.h has
> > two includes pointing to /usr/include/. IMHO, the fix for this is:
> >
> > --- obs-frontend-api.h.orig     2021-09-06 23:17:30.132174882 -0300
> > +++ obs-frontend-api.h  2021-09-06 23:17:04.324371729 -0300
> > @@ -1,7 +1,7 @@
> >  #pragma once
> >
> > -#include <obs.h>
> > -#include <util/darray.h>
> > +#include <obs/obs.h>
> > +#include <obs/util/darray.h>
>
> I will check that and see what needs fixing.

Thanks! If possible, fix it also in Bullseye, to make possible a
backport of the plugin.

I am grateful for your attention.

Cheers,

Eriberto

Reply via email to