On 9/23/21 3:43 AM, Joshua Peisach wrote: > Package: sponsorship-requests > Severity: wishlist > > Dear mentors, > > I am looking for a sponsor for my package "pyupgrade": > > * Package name : pyupgrade > Version : 2.24.0-1 > Upstream Author : Anthony Sottile <asott...@umich.edu> > * URL : https://github.com/asottile/pyupgrade > * License : MIT > * Vcs : https://salsa.debian.org/python-team/packages/pyupgrade > Section : devel > > It builds those binary packages: > > pyupgrade - Tool to automatically upgrade Python 3 syntax for newer versions > > To access further information about this package, please visit the following > URL: > > https://mentors.debian.net/package/pyupgrade/ > > Alternatively, one can download the package with dget using this command: > > dget -x > https://mentors.debian.net/debian/pool/main/p/pyupgrade/pyupgrade_2.24.0-1.dsc > > Changes for the initial release: > > pyupgrade (2.24.0-1) unstable; urgency=medium > . > * Initial packaging > * Fix lintian issues, cleanup and add a few extra essentials > . > * Initial release (Closes: #988658) > > Regards, > -- > Joshua Peisach
Hi Joshua, Here's my review. 1/ override_dh_auto_clean Instead of overriding dh_auto_clean, it'd be nicer to add: extend-diff-ignore = "^[^/]*[.]egg-info/" to debian/source/options. In fact, you have it there already, so why attempting to clean the egg-info? 2/ debian/gbp.conf Please remove the file completely. It's annoying to maintain. One can simply use: ignore-branch = True in ~/.gbp.conf instead. 3/ debian/copyright This isn't mandatory, but I strongly advise to use the same license as upstream for your packaging. Is there a good reason why you wrote debian/* in GPL-2+ instead of Expat like upstream? 4/ debian/control Please run "wrap-and-sort -bastk" to clean-up indentation in d/control. The package has, in setup.cfg: install_requires = tokenize-rt>=3.2.0 however, you do not (build-)depends on it. Can you fix this? You probably will have to package it too (since I didn't find it in Debian). 5/ debian/changelog Please only write a single entry there: Initial release (Closes: #988658) and nothing more. Let me know when all of the above is fixed, and I'll review the package again for sponsoring. Thomas Goirand (zigo)