Hi,

On Mon, 23 Dec 2019 11:03:33 +0100 Joerg Dorchain <jo...@dorchain.net> wrote:
> Package: ifupdown
> Version: 0.8.35
> Tags: Patch
> Severity: wishlist
> 
> Hi,
> 
> please include the restart-ms option in the can static method, e.g as per
> attached patch.
> 
> Thanks for considering.
> 
> Bye,
> 
> Joerg
> 
> 
> --- ifupdown-0.8.35.orig/can.defn     2018-10-29 22:29:33.000000000 +0100
> +++ ifupdown-0.8.35/can.defn  2019-12-23 11:00:03.421389325 +0100
> @@ -14,6 +14,7 @@
>      triple triple            -- activate triple sampling (on|off)
>      oneshot oneshot          -- one shot mode (on|off)
>      berr berr                        -- activate berr reporting (on|off) 
> +    restart-ms restart-ms    -- restart-ms (0..)
>  
>    up
>      ip link set %iface% type can bitrate %bitrate%
> @@ -22,6 +23,7 @@
>      [[ ip link set %iface% type can triple-sampling %triple% ]]
>      [[ ip link set %iface% type can one-shot %oneshot% ]]
>      [[ ip link set %iface% type can berr-reporting %berr% ]]
> +    [[ ip link set %iface% type can restart-ms %restart-ms% ]]
>      ip link set %iface% up
>  
>    down
> 

Thanks for your patch. I cannot test it by myself but I suppose it is OK
to include it. However, could you please document this option in your
patch? You may include it in interfaces(5)

Thanks,

 -- Santiago

Reply via email to