Package: fish Version: 3.3.1+ds-1 Severity: normal X-Debbugs-Cc: jspri...@debian.org
Hi, thanks for uploading the new fish version. Sadly it has a regression for me due to the patch for #985153. I set $PATH in my ~/.xsession¹ so all fish open below it will get it from the environment. The patch for #985153 in /etc/fish/config.fish resets $PATH so this does not work anymore. You can reproduce the same with: $ PATH="/tmp:$PATH" fish -c 'echo $PATH' /usr/local/bin /usr/bin /bin /usr/local/games /usr/games The patch can be disabled with FISH_UNIT_TESTS_RUNNING=1: FISH_UNIT_TESTS_RUNNING=1 PATH="/tmp:$PATH" fish -c 'echo $PATH' /tmp /usr/local/bin /usr/bin /bin /usr/local/games /usr/games Whereas other shells: $ PATH=/bin dash -c 'echo $PATH' /bin $ PATH=/bin bash -c 'echo $PATH' /bin This is because /etc/profile is only read for login shells: $ PATH=/bin:/usr/bin dash -l -c 'echo $PATH' /usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games So we should encapsulate the patch in `if status is-login`. Also /usr/share/fish/vendor_conf.d is probably a better home then /etc/fish/config.fish. I will test this locally tomorrow and upload a new version (due to LowNMU) if you don't disagree. Also, the new version is missing the man pages, I will try to recover them as well. Cheers Jochen ¹: Actually I set it in ~/.profile and use a variable to make sure it is only set once but that should not matter for this bug report. -- System Information: Debian Release: bookworm/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 5.14.0-4-amd64 (SMP w/8 CPU threads) Kernel taint flags: TAINT_WARN Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages fish depends on: ii bc 1.07.1-3+b1 ii chromium [www-browser] 93.0.4577.82-1 ii dpkg 1.20.9 ii firefox [www-browser] 94.0-2 ii fish-common 3.3.1+ds-1 ii libc6 2.32-4 ii libpcre2-32-0 10.39-2 ii libstdc++6 11.2.0-10 ii libtinfo6 6.3-1 ii lynx [www-browser] 2.9.0dev.10-1 ii man-db 2.9.4-2 ii python3 3.9.7-1 ii python3-distutils 3.9.8-1 ii w3m [www-browser] 0.5.3+git20210102-6 Versions of packages fish recommends: pn xsel <none> Versions of packages fish suggests: pn doc-base <none> -- no debconf information
