Yadd:

Looking better, I think we do have a small problem here:

On Fri, Nov 19, 2021 at 08:16:37PM +0100, Michael Biebl wrote:
> uscan info: Looking at $base = https://github.com/systemd/systemd-stable/tags 
> with
>     $filepattern = .*/v?(\d\S*)\.tar\.gz found
>     $newfile     = 
> https://github.com/systemd/systemd-stable/archive/refs/tags/v249.7.tar.gz
>     $newversion  = 249.7
>     $lastversion = 249.6
> uscan info: Matching target for downloadurlmangle: 
> https://github.com/systemd/systemd-stable/archive/refs/tags/v249.7.tar.gz
> uscan info: Upstream URL(+tag) to download is identified as    
> https://github.com/systemd/systemd-stable/archive/refs/tags/v249.7.tar.gz
> uscan info: Matching target for filenamemangle: v249.7.tar.gz
> uscan die: filenamemangle failed for v249.7.tar.gz at 
> /usr/share/perl5/Devscripts/Uscan/Output.pm line 60.
...
> uscan info: Looking at $base = https://github.com/systemd/systemd-stable/tags 
> with
>     $filepattern = .*/v?(\d\S*)\.tar\.gz found
>     $newfile     = 
> https://github.com/systemd/systemd-stable/archive/refs/tags/v249.7.tar.gz
>     $newversion  = 249.7
>     $lastversion = 249.6
> uscan info: Matching target for downloadurlmangle: 
> https://github.com/systemd/systemd-stable/archive/refs/tags/v249.7.tar.gz
> uscan info: Upstream URL(+tag) to download is identified as    
> https://github.com/systemd/systemd-stable/archive/refs/tags/v249.7.tar.gz
> uscan info: Matching target for filenamemangle: 
> https://github.com/systemd/systemd-stable/archive/refs/tags/v249.7.tar.gz
> uscan info: Filename (filenamemangled) for downloaded file: 
> systemd-249.7.tar.gz


I went to better read the relevant documentation:

       filenamemangle=rules
           Generate the upstream tarball filename from the selected href
           string if matching-pattern can extract the latest upstream
           version <uversion> from the selected href string.  Otherwise,
           generate the upstream tarball filename from its full URL
           string and set the missing <uversion> from the generated
           upstream tarball filename.

That text is very confusing to me, but it does say that the rules, in
some cases, are matched against the full URL.

In particular, it means that any matching-pattern that has ".*" as
leading characters will most likely have a full URL here to match
against.


So, effectively, the change broke the specification.

This apparently came as a result to https://bugs.debian.org/993585 -
which was really complaining about pgpsigurlmangle but it ended up
affecting filenamemangle too.

In fact, I believe reverting 9e65c07737425748e396291d9c20442d11b0641b
fixes this bug, but probably reopens that other one.


-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
More about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature

Reply via email to