Hi, On Thu, Nov 25, 2021 at 07:30:45PM +0800, Zhang Boyang wrote: > It seems my last email was marked spam. It's strange that the bug tracker > has received my reply but the mailing list didn't. Please correct me if I > misunderstand the situation.
Indeed, looks like your mail was dropped at some point. If you supply sufficient details listmasters might be able to tell you what exactly went wrong. (The BTS seems to assign your mails ~ -10 points which is very good, but at the same time the list mail which passed through got 0, which is not bad, but also not particular good citing e.g. "MIME_BASE64_TEXT_BOGUS(1) R_DKIM_REJECT(1)". With patches you might be better of in salsa btw.) > The patch is attached again for convenience. This patch implemented Anders's > idea. The signal handler will only set a flag. After signal handler > completed, the pselect() in pkgDPkgPM::Go() will return immediately with > errno set to EINTR. Then, progress->Pluse() is called by pkgDPkgPM::Go(), > and PackageManagerFancy::Pluse() will redraw the status bar. Not having looked at the issue itself I just gave the patch a casual glance: PackageManagerFancy is a public – hence exported – interface, so you can't change member variables or add virtual methods as that breaks the ABI. At some point we will have one I am sure, but if at all possible it could be better to investigate if that can be solved some other way. (Not exactly sure why that is public at all, given there seems to also be a factory function to be able to hide it?) Can we perhaps make it (still) easier to reproduce? apt can be told to use a different dpkg via Dir::Bin::dpkg – can we have that be a script which just spits out 'offending' lines (= is it the fd messages or the messages on stdout for example – or both) ? (Sorry for not being very specific at the moment as I am a bit starved for Debian time; will try to give that some proper thought/review ~next week) Best regards David Kalnischkies
signature.asc
Description: PGP signature
