Hi Nicholas, On 01/12/2021 18:09, Nicholas D Steeves wrote: > Once again, if you find these changes boring/not worth your time, then I > can take care of them (unless you're working towards Debian Maintainer, > uploading status, where it will better support your application to have > done this yourself).
I was unpleasantly busy the last weeks, but I finally should have more time in the next few weeks. > Is there any reason you've chosen debhelper-compat 12 rather than 13? > If not, please use 13. This isn't release critical, so I'm ok with 12 > (a luckier number), but it creates a bit more work later (diffoscoping > to check for differences between builds with 12 vs builds with 13) . I have changed that. > control: > > * source:Description does not yet appear to be supported by Policy > (see bug #998165). I'm guessing you would prefer to prioritise > uploading this package rather than waiting for (or working towards) > evolving Debian Policy, so I'd recommend just copy and pasting for now. > For the record, yes, I absolutely agree that the way you chose is better > :-) I look forward to the day when we can upload this more elegant > packaging style. So lintian has been updated already. If you insist, I change back to using the X-Description variable (which is allowed by the policy). > * "libmartchus-qtutilities6-dev" should be "Section: libdevel" > (bin:pkgs can be in different sections from each other, and of course > from the src:pkg) I was not aware of that. I have changed that. > * Please make this package compliant with Policy 4.6.0, since this is > what is now relevant for new packages ( > https://www.debian.org/doc/debian-policy/upgrading-checklist.html > <https://www.debian.org/doc/debian-policy/upgrading-checklist.html> ). > This also applies to martchus-cpp-utilities. For the initial upload of > a package there's no need to add a changelog entry for this action, but > for subsequent uploads it's best practises to add the line " * Declare> > Standards-Version: x.y.z (no changes required)." Done. > copyright: > > * Where did you get the date range "2016-2021 Marchus"? Please > document where you found it, and/or how you established that it was > valid using the "Comment" field ( > https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#comment-field > <https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#comment-field> > ) > > Other than that, so far it looks good. I'll wait for your reply before > creating the repo. Also, that repo will be created with the name > "martchus-qtutilities". Sounds good. > Oh yeah, if we're comaintaining these packages then it would be nice to > see the following line added to both marchus-libs/control files: > "Uploaders: Nicholas D Steeves <s...@debian.org > <mailto:s...@debian.org>>". This line conventionally goes just > underneath the Maintainer one. I can add it later, but if you prefer to > be the sole named contributor, that's cool too! Done. I'll be going through the rest of your comments in the next days. All my changes are on Salsa. Regards, Hannah