Package: phalanx
Version: 22+d051004-14
Severity: normal
Tags: patch
Dear Maintainer,
* What led up to the situation?
Saw gcc compilation warning for line 864 in io.c: pointer value compared
to byte value:
while (isdigit((int)*f) && f != '\0') /* find the end of the fifty-move
info */
* What exactly did you do (or not do) that was effective (or
ineffective)?
Changed code to dereference variable "f":
while (isdigit((int)*f) && *f != '\0') /* find the end of the fifty-move
info */
I thought this change was reasonable for the following reasons:
1) "f" was already dereferenced earlier in the statement, implying f not
NULL
2) there is a nearly identical statement on line 886 where f is
dereferenced
3) there are other comparisons of *f to '\0' in that function.
* What was the outcome of this action?
The compilation warning is gone and the executable runs.
However, this new version did choose a different starting move in a middle
game that
I specified with the setboard command:
setboard 2k5/1pp3pp/7r/n3pp2/8/N1PP1P1P/P3KP2/1R6 w - - 0 1
In the new version, phalanx plays Pf3-f4 but the older verson plays
Rb1-b5.
* What outcome did you expect instead?
N/A
-- System Information:
Debian Release: 10.11
APT prefers oldstable-updates
APT policy: (500, 'oldstable-updates'), (500, 'oldstable')
Architecture: i386 (i686)
Kernel: Linux 4.19.0-18-686-pae (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)
Versions of packages phalanx depends on:
ii debconf [debconf-2.0] 1.5.71+deb10u1
ii libc6 2.28-10
phalanx recommends no packages.
Versions of packages phalanx suggests:
ii xfce4-terminal [x-terminal-emulator] 0.8.8-0mx19+1
-- debconf information:
phalanx/learning_file_erase: true
phalanx/learning_file_size: 32768
