(Removing some people from CC to avoid polluting their mailboxes)

El 25/02/22 a las 11:25, Martin-Éric Racine escribió:
> On Fri, Feb 25, 2022 at 10:31 AM Roy Marples <r...@marples.name> wrote:
> >
> > On 24/02/2022 21:31, Santiago R.R. wrote:
> >  >
> >  > On February 24, 2022 10:21:38 PM GMT+01:00, "Santiago R.R."
> > <santiag...@riseup.net> wrote:
> >  >>
> >  >> On February 24, 2022 9:38:36 AM GMT+01:00, "Martin-Éric Racine"
> > <martin-eric.rac...@iki.fi> wrote:
> >  >>> Package: dhcpcd5
> >  >>> Followup-For: Bug #964947
> >  >>> X-Debbugs-Cc:
> > sc...@sl.id.au,r...@marples.name,santiag...@riseup.net,mp...@debian.org
> >  >>>
> > > I have an NMU waiting on Mentors.
> > >
> > > <https://mentors.debian.net/debian/pool/main/d/dhcpcd5/dhcpcd5_9.4.1-0.1.dsc>
> > >
> > >> Thanks for your work! I do not have too much free cycles, but I will do 
> > >> my best to review and upload it soon.
...

I forgot to say I hope Scott is doing well. I hope his lack of activity
is just a lack of available time.


Martin-Éric, thank you again for preparing this NMU. Here you have some
comments/questions:

* You are moving stuff to /usr. Do you have any reason for making this
  change in this NMU?
  While I think it is a good thing, this is not documented in
  d/changelog, and I think an NMU should focus on the reason for doing it
  (the newest upstream release in this case).
  From the developers reference (5.11.1.): "...Fixing cosmetic issues or
  changing the packaging style in NMUs is discouraged."

  This also concerns the minor bump version number in d/watch.

* Could you please fix the indentation of the your new entry in d/copyright?

* Part of the changes you are including had already been done in the VCS
  by Scott. There is no rule about this, but *I* would give credit to
  him. Maybe I would have cherry-picked the relevant changes needed for
  packaging this new upstream release, and use `gdp dch`. This is up to
  you.

* Could you please tell me how have you tested it?

(I will answer Roy's messages in another mail)

Cheers!

 -- Santiago

Attachment: signature.asc
Description: PGP signature

Reply via email to