[ adding back bugreport as email recipient ] Ayoyimika, please beware that this conversation is held via a bugreport.
Please do not reply only to me, but send your reply also to the bugreport. Quoting Ayoyimika Ajibade (2022-03-15 15:19:40) > pls what is ABI? Application Binary Interface - i.e. the interface offered by a code project for runtime use: https://en.wikipedia.org/wiki/Application_binary_interface Your patch changes that interface - see NodeJS documentation here: https://nodejs.org/api/packages.html#main-entry-point-export Specifically, NodeJS documentation says this: > This encapsulation of exports provides more reliable guarantees about > package interfaces for tools and when handling semver upgrades for a > package. Apparently, the authors of eslint-scope chose to treat referencer.js as a _private_ library. Maybe they did that for a good reason. > waiting for upstream to patch node-eslint-scope to expose the > directory in the package.json export fields may take some time and > almost all webpack5 reverse dependencies are failing because of that. We want code that is _maintainable_ for several years. If you want quick dirty hacks then apply those hacks at the _receiving_ end - i.e. by hardcoding path to the private library file in webpack or axios or whereever exactly it is (wrongly!) expected. > i think exposing a directory shouldn't be causing any breaking changes. > here is the patch I will be forwarding upstream: > https://salsa.debian.org/Ayoyimika/node-eslint-scope/-/commit/b696752c23863d7c98fabcd3da52fcdb945da2b8.patch Please share that with upstream, so that we can learn their opinion on the matter. We don't need to wait for them to issue a new release, maybe their response in the bugreport is enough to convince us. > >Where did you ask those questions? > >On our IRC channel? At our mailinglist? In a bugreport? > i asked the question via Matrix Ah, ok. Our chat channels/rooms are mostly for casual conversation - if you don't get a response there, then try post an email to our mailinglist. Kind regards, - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature