Package: pahole
Version: 1.22-8
Severity: serious
User: debian...@lists.debian.org
Usertags: piuparts replaces-without-breaks

Hi,

during a test with piuparts and DOSE tools I noticed your package causes
removal of files that also belong to another package.
This is caused by using Replaces without corresponding Breaks.

The installation sequence to reproduce this problem is

  apt-get install dwarves/stable
  # (1)
  apt-get install pahole
  apt-get remove pahole
  # (2)

The list of installed files at points (1) and (2) should be identical,
but the following files have disappeared:

  /usr/bin/btfdiff
  /usr/bin/codiff
  /usr/bin/ctracer
  /usr/bin/dtagnames
  /usr/bin/fullcircle
  /usr/bin/pahole
  /usr/bin/pdwtags
  /usr/bin/pfunct
  /usr/bin/pglobal
  /usr/bin/prefcnt
  /usr/bin/scncopy
  /usr/bin/syscse
  /usr/share/dwarves/runtime/Makefile
  /usr/share/dwarves/runtime/ctracer_relay.c
  /usr/share/dwarves/runtime/ctracer_relay.h
  /usr/share/dwarves/runtime/linux.blacklist.cu
  /usr/share/man/man1/pahole.1.gz

This is a serious bug violating policy 7.6, see
https://www.debian.org/doc/debian-policy/ch-relationships.html#overwriting-files-and-replacing-packages-replaces
and also see the footnote that describes this incorrect behavior:
https://www.debian.org/doc/debian-policy/ch-relationships.html#id13

The pahole package has the following relationships with dwarves:

  Conflicts: n/a
  Breaks:    n/a
  Replaces:  dwarves (<< 1.22)

>From the attached log (scroll to the bottom...):

0m33.5s DEBUG: Modified(user, group, mode, size, target): 
/var/lib/dpkg/info/dwarves.list expected(root, root, - 100644, 697, None) != 
found(root, root, - 100644, 292, None)
0m33.5s ERROR: FAIL: After purging files have disappeared:
  /usr/bin/btfdiff       owned by: pahole
  /usr/bin/codiff        owned by: pahole
  /usr/bin/ctracer       owned by: pahole
  /usr/bin/dtagnames     owned by: pahole
  /usr/bin/fullcircle    owned by: pahole
  /usr/bin/pahole        owned by: pahole
  /usr/bin/pdwtags       owned by: pahole
  /usr/bin/pfunct        owned by: pahole
  /usr/bin/pglobal       owned by: pahole
  /usr/bin/prefcnt       owned by: pahole
  /usr/bin/scncopy       owned by: pahole
  /usr/bin/syscse        owned by: pahole
  /usr/share/dwarves/runtime/Makefile    owned by: pahole
  /usr/share/dwarves/runtime/ctracer_relay.c     owned by: pahole
  /usr/share/dwarves/runtime/ctracer_relay.h     owned by: pahole
  /usr/share/dwarves/runtime/linux.blacklist.cu  owned by: pahole
  /usr/share/man/man1/pahole.1.gz        owned by: pahole

0m33.5s ERROR: FAIL: After purging files have been modified:
  /var/lib/dpkg/info/dwarves.list        not owned


cheers,

Andreas

Attachment: dwarves=1.20-1_pahole=1.22-8.log.gz
Description: application/gzip

Reply via email to