Bug#1008773: ftpsync: Using commands with parameters as hooks breaks ftpsync on bullseye/debian 11

[Raphael Hertzog]

Control: tags -1 + patch

I have prepared a merge request with a fix for this issue:
https://salsa.debian.org/mirror-team/archvsync/-/merge_requests/4

(Note that there's another outstanding merge request there that you might
want to merge too)

I'm attaching the patch as well.
-- 
  ⢀⣴⠾⠻⢶⣦⠀   Raphaël Hertzog <hert...@debian.org>
  ⣾⠁⢠⠒⠀⣿⡁
  ⢿⡄⠘⠷⠚⠋    The Debian Handbook: https://debian-handbook.info/get/
  ⠈⠳⣄⠀⠀⠀⠀   Debian Long Term Support: https://deb.li/LTS

>From e714ee57d5ee639e0726829114b2f913f1e8941b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Hertzog?= <raph...@offensive-security.com>
Date: Fri, 1 Apr 2022 09:48:29 +0200
Subject: [PATCH] Properly quote HOOKSCR assignations

Otherwise ftpsync is failing with bash 5.1 with errors like this:
ftpsync: line 276: local: `hook-parameter': not a valid identifier

Closes: #1008773
---
 bin/ftpsync | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/bin/ftpsync b/bin/ftpsync
index 99a2ceb..25cefe5 100755
--- a/bin/ftpsync
+++ b/bin/ftpsync
@@ -591,7 +591,7 @@ fi
 
 HOOK=(
     HOOKNR=1
-    HOOKSCR=${HOOK1}
+    HOOKSCR="${HOOK1}"
 )
 hook $HOOK
 
@@ -651,7 +651,7 @@ while [[ -e ${UPDATEREQUIRED} ]]; do
 
     HOOK=(
         HOOKNR=2
-        HOOKSCR=${HOOK2}
+        HOOKSCR="${HOOK2}"
     )
     hook $HOOK
 
@@ -720,7 +720,7 @@ while [[ -e ${UPDATEREQUIRED} ]]; do
 
     HOOK=(
         HOOKNR=3
-        HOOKSCR=${HOOK3}
+        HOOKSCR="${HOOK3}"
     )
     hook $HOOK
 done
@@ -739,7 +739,7 @@ fi
 
 HOOK=(
     HOOKNR=4
-    HOOKSCR=${HOOK4}
+    HOOKSCR="${HOOK4}"
 )
 hook $HOOK
 
@@ -782,7 +782,7 @@ if [[ ${HUB} = true ]]; then
 
         HOOK=(
             HOOKNR=5
-            HOOKSCR=${HOOK5}
+            HOOKSCR="${HOOK5}"
         )
         hook $HOOK
     fi
-- 
2.35.1