Hi Mike, Juri,

On Sun, Jun 05, 2022 at 07:50:20PM +0000, Mike Gabriel wrote:
> Hi Salvatore,
> 
> On  So 05 Jun 2022 14:35:03 CEST, Salvatore Bonaccorso wrote:
> 
> > Hi,
> > 
> > On Sun, Jun 05, 2022 at 12:02:54PM +0000, Mike Gabriel wrote:
> > > Hi Juri,
> > > 
> > > On  Sa 04 Jun 2022 00:13:11 CEST, debian wrote:
> > > 
> > > > Hello,
> > > >
> > > > here is draft for MR:
> > > > https://salsa.debian.org/horde-team/php-horde-turba/-/merge_requests/1
> > > > I would look after it next time on sunday evening.
> > > >
> > > > @Mike: Can you please review it?
> > 
> > it looks that the force pushed commit two days ago adjusted two
> > further create() -> createTrusted() stances in lib/Application.php,
> > can you double check?
> 
> I actually did double check already, applied 9f242132 and saw that it did
> not apply properly (and thus reverted). See Git history at [1]. It seems
> that the backup/restore API calls (where these two spots of create ->
> createTrusted had been added) were not part of the 4.2.25 upstream release
> of turba.
> 
> > https://github.com/horde/turba/commit/9f2521328aa7d0dbd905591eca138c8e7580d673
> > (which is not yet merged, but compare to the used
> > https://github.com/horde/turba/commit/784da95e0190321b08ceeb27e2cb6c7505f2057c).
> > 
> > p.s.: the upload did contain a non valid bug closer, which in case the
> > above is correct cha be simply closed in a 4.2.25-7 upload.
> 
> If you agree, we have to close the bug manually as Juri's approach already
> contained the right patch.

yes, thank you!

Salvatore

Reply via email to