Hello Josch,

thank you for your very fast feedback.

You are right, I shall revert my changes, and put proposed changes
in a separate branch of the git tree, so it will be easier to
cherry-pick them.

Best regards,                   Georges.

Johannes Schauer Marin Rodrigues a écrit :
> Hi Georges,
> 
> Quoting Georges Khaznadar (2022-06-13 10:56:28)
> > Bug #1012622 in base-passwd reported by you has been fixed in the
> > Git repository and is awaiting an upload. You can see the commit
> > message below and you can check the diff of the fix at:
> > 
> > https://salsa.debian.org/debian/base-passwd/-/commit/5ce77739fb387ba36f7bb75570af63aec038d963
> > 
> > ------------------------------------------------------------------------
> > frozen the group id for crontab, closes: #1012622
> > ------------------------------------------------------------------------
> > 
> > (this message was generated automatically)
> 
> I don't think this is a good solution:
> 
> https://salsa.debian.org/debian/base-passwd/-/commit/e1a186baa5cec0ee1ffed6a06344bc2a492c3e3d
> 
> I'm putting Colin as the base-passwd maintainer into CC.
> 
> Firstly, I don't think you should statically allocate group 101 like this
> because that's inside the 100-999 range which is dynamically allocated:
> 
> https://www.debian.org/doc/debian-policy/ch-opersys.html#uid-and-gid-classes
> 
> Secondly, each new group should be documented. Introducing a new group 
> probably
> needs documentation in doc/users-and-groups.sgml as it is for example done
> here:
> 
> https://salsa.debian.org/debian/base-passwd/-/commit/af62feef458e3787bd460a2822d402d5a970b237
> 
> Did you discuss this change with Colin? Otherwise, maybe you first want to
> revert your changes to not cause any accidental damage. I think Colin needs to
> have a say in to whether or not a statically allocated crontab group 
> maintained
> by base-passwd is a good idea or not.
> 
> Thanks!
> 
> cheers, josch



-- 
Georges KHAZNADAR et Jocelyne FOURNIER
22 rue des mouettes, 59240 Dunkerque France.
Téléphone +33 (0)3 28 29 17 70

Attachment: signature.asc
Description: PGP signature

Reply via email to