On 2022-05-17, Rémi Denis-Courmont wrote: > On Wed, 23 Jun 2021 13:24:23 -0700 Vagrant Cascadian <vagrant@reproducible- > builds.org> wrote: >> In share/Makefile.am, when creating default.vlt it attempts to detect >> the availability of the tar --sort= option, but then incorrectly passes >> the variable to tar. >> >> It does not appear to affect the sort order on >> tests.reproducible-builds.org, but it does appear to cause issues when >> testing with reprotest, and so may occur in other situations in the >> wild. >> >> >> The attached patch fixes this by passing it as a make variable rather >> than a quoted shell variable. > > Such a patch should be submitted upstream but for a start, it does not look > right to me. Specifically $$tarsort is correct.
Ok, will try to take this upstream. > AFAICT, the problem is that predicate for the assignment relies on > locale-dependent behaviour and thus fails with non-English languages. This also apparently happens with the C.UTF-8 locale: https://buildd.debian.org/status/fetch.php?pkg=vlc&arch=amd64&ver=3.0.17.4-4%2Bb1&stamp=1656788338&raw=0 tarsort= ; \ tar --help|grep -q sort=ORDER && tarsort=--sort=name ; \ GZIP=--no-name \ tar cvvzf skins2/default.vlt.tmp \ --format=ustar $tarsort \ --owner=root --group=root --directory="./skins2" \ default/ live well, vagrant p.s. please CC the submitter or nnn-submit...@bugs.debian.org if you want them to notice!
signature.asc
Description: PGP signature
