Source: broadcom-sta
Version: 6.30.223.271-20
Severity: important
Tags: patch
X-Debbugs-Cc: die...@gnome.org

Dear Maintainer,

The patch for linux-5.17 deprecations incorrectly inverted the src/dest
of the copying of MAC addresses.

I have pushed a branch with the gbp-processed patch:
  https://salsa.debian.org/diegoe/broadcom-sta/-/tree/debian-diegoe-202208

I _think_ this potentially fixes two recent bugs that have the trace/bug
in the logs, but my card is a different PHY so I can't confirm that.

Here's the commit log for further explanation:

```
  d/patches: Fix the linux-5.17 deprecations patch

  The patch was enough to get things to build, but it accidentally
  inverted the direction of the copy of a few addresses.

  This was causing traces when the device address was set in the driver:

  ```
      wl 0000:03:00.0 wlp3s0: Current addr:  NN NN NN NN NN NN 00 00 00 00 00 
00 00 00 00
      wl 0000:03:00.0 wlp3s0: Expected addr: 00 00 00 00 00 00 00 00 00 00 00 
00 00 00 00
      ------------[ cut here ]------------
      netdevice: wlp3s0: Incorrect netdev->dev_addr
      WARNING: CPU: 3 PID: 1178 at net/core/dev_addr_lists.c:517 
dev_addr_check.cold+0x43/0x7d
      (...)
  ```

  (where NN is the device MAC)

  Apparently this might be enough in some cards to make it impossible to
  connect to a network. See bugs below.

  See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011529
  See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016426
```

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.18.0-3-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_USER, TAINT_WARN, 
TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=UTF-8 (charmap=UTF-8) (ignored: LC_ALL set 
to en_US.UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Reply via email to