Control: retitle -1 mimedefang: Debian's config change from /etc to /etc/mail 
is incomplete and broken
Control: severity -1 important

as without looking at the source, it's impossible to know what is
going on.

So it appears in

  debian/patches/Makefile.patch
  debian/patches/confdir.patch

that Debian changes "/etc" to "/etc/mail", but this change is not
done everywhere!

In debian/patches/Makefile.patch, one has

-       if test -f $(DESTDIR)${CONFDIR}/mimedefang-filter ; then \
-               $(INSTALL) -m 644 
examples/suggested-minimum-filter-for-windows-clients 
$(DESTDIR)${CONFDIR}/mimedefang-filter.example || exit 1; \
+       if test -f $(DESTDIR)${sysconfdir}/mail/mimedefang-filter ; then \
+               $(INSTALL) -m 644 
examples/suggested-minimum-filter-for-windows-clients 
$(DESTDIR)${sysconfdir}/mail/mimedefang-filter.example || exit 1; \
        else \
-               $(INSTALL) -m 644 
examples/suggested-minimum-filter-for-windows-clients 
$(DESTDIR)${CONFDIR}/mimedefang-filter || exit 1; \
+               $(INSTALL) -m 644 
examples/suggested-minimum-filter-for-windows-clients 
$(DESTDIR)${sysconfdir}/mimedefang-filter || exit 1; \
        fi

The "mail/" is missing in the "else" case. So the default config file
is installed at the wrong place, which yields an error with
"mimedefang.pl -features".

One may wonder whether such a complex config file should be installed
by default instead of just being an example, but that's another issue
(IMHO, the default config file should just be a skeleton that does
nothing by default, with commented suggestions).

The changes in the man pages are also incomplete: mimedefang.pl(8) and
mimedefang-multiplexor(8) both say "/etc/mimedefang-filter" instead of
"/etc/mail/mimedefang-filter".

Moreover, in the mimedefang-filter(5) man page, I'm wonderning about
"/etc/mail/mimedefang-filter.pl". Shouldn't this be
"/etc/mail/mimedefang-filter"?

Please also check that mimedefang-filter(5) is correct about
"sa-mimedefang.cf".

-- 
Vincent Lefèvre <[email protected]> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Reply via email to