Hi!

On Sun, 2022-09-11 at 12:29:41 +0200, Helmut Grohne wrote:
> Source: unace
> Version: 1.2b-21
> Tags: patch
> User: [email protected]
> Usertags: ftcbfs

> your -21 upload broke cross building by adding CC=$(CC) without
> initializing $(CC) properly. As far as I understand it, you deliberately
> added it to override the upstream choice (e.g. for supporting clang
> builds). Unfortunately, you failed to add proper initialization.
> Possibly, you thought that buildtools.mk was part of default.mk so that
> was sufficient, but it is not as of today.

Cannot recall what was the train of thought there TBH. :/

> Please either include it or
> change default.mk in dpkg. I'm attaching a patch for the former for your
> convenience.

I'm afraid the builtools.mk was not added to default.mk on purpose, to
avoid breakage. I've now added this commit to the dpkg-build-api
branch and to the spec on the wiki:

  
https://git.hadrons.org/cgit/debian/dpkg/dpkg.git/commit/?h=pu/perl-Dpkg-BuildAPI&id=cddecf191ed4c50536b625e4e370d733b083bf54

In any case, thanks! I've merged your patch and I'm uploading a fixed
package right away.

[ Would be nice to have cross building status on DDPO or the UDD
  dashboard, as that's the main reason I've missed this. :/ ]

Regards,
Guillem

Reply via email to