Package: libhttrack-dev
Version: 3.49.2-1.1+b1
Severity: wishlist
X-Debbugs-Cc: bernha...@mailbox.org
Dear Maintainer,
currently the header htsglobal.h generates many warnings in
build of depending package httraqt.
/usr/include/httrack/htsglobal.h:211:28: warning: invalid suffix on literal;
C++11 requires a space between literal and string macro [-Wliteral-suffix]
211 | #define HTS_DEFAULT_FOOTER "<!-- Mirrored from %s%s by HTTrack Website
Copier/"HTTRACK_AFF_VERSION" "HTTRACK_AFF_AUTHORS", %s -->"
Attached a diff to add those few spaces to htsglobal.h.
Kind regards,
Bernhard
-- System Information:
Debian Release: bookworm/sid
APT prefers testing-debug
APT policy: (500, 'testing-debug'), (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 5.19.0-2-amd64 (SMP w/16 CPU threads; PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages libhttrack-dev depends on:
ii libc6 2.35-2
ii libhttrack2 3.49.2-1.1+b1
ii zlib1g-dev 1:1.2.11.dfsg-4.1
libhttrack-dev recommends no packages.
libhttrack-dev suggests no packages.
-- no debconf information
From cd855083532d8146d00694fafdb480f17fc7ccee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bernhard=20=C3=9Cbelacker?= <bernha...@mailbox.org>
Date: Sun, 9 Oct 2022 17:13:49 +0200
Subject: Avoid warning because of missing space between literal and string
macro.
/usr/include/httrack/htsglobal.h:211:28: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
211 | #define HTS_DEFAULT_FOOTER "<!-- Mirrored from %s%s by HTTrack Website Copier/"HTTRACK_AFF_VERSION" "HTTRACK_AFF_AUTHORS", %s -->"
---
..._space_between_literal_and_string_macro.patch | 16 ++++++++++++++++
debian/patches/series | 1 +
2 files changed, 17 insertions(+)
create mode 100644 debian/patches/10_avoid_warning_because_missing_space_between_literal_and_string_macro.patch
create mode 100644 debian/patches/series
diff --git a/debian/patches/10_avoid_warning_because_missing_space_between_literal_and_string_macro.patch b/debian/patches/10_avoid_warning_because_missing_space_between_literal_and_string_macro.patch
new file mode 100644
index 0000000..0cf02cb
--- /dev/null
+++ b/debian/patches/10_avoid_warning_because_missing_space_between_literal_and_string_macro.patch
@@ -0,0 +1,16 @@
+diff --git a/src/htsglobal.h b/src/htsglobal.h
+index 65ba1c6..72139e3 100644
+--- a/src/htsglobal.h
++++ b/src/htsglobal.h
+@@ -208,9 +208,9 @@ Please visit our Website: http://www.httrack.com
+
+ /* Copyright (C) 1998-2017 Xavier Roche and other contributors */
+ #define HTTRACK_AFF_AUTHORS "[XR&CO'2014]"
+-#define HTS_DEFAULT_FOOTER "<!-- Mirrored from %s%s by HTTrack Website Copier/"HTTRACK_AFF_VERSION" "HTTRACK_AFF_AUTHORS", %s -->"
++#define HTS_DEFAULT_FOOTER "<!-- Mirrored from %s%s by HTTrack Website Copier/" HTTRACK_AFF_VERSION " " HTTRACK_AFF_AUTHORS ", %s -->"
+ #define HTTRACK_WEB "http://www.httrack.com";
+-#define HTS_UPDATE_WEBSITE "http://www.httrack.com/update.php3?Product=HTTrack&Version="HTTRACK_VERSIONID"&VersionStr="HTTRACK_VERSION"&Platform=%d&Language=%s";
++#define HTS_UPDATE_WEBSITE "http://www.httrack.com/update.php3?Product=HTTrack&Version="; HTTRACK_VERSIONID "&VersionStr=" HTTRACK_VERSION "&Platform=%d&Language=%s"
+
+ #define H_CRLF "\x0d\x0a"
+ #define CRLF "\x0d\x0a"
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..fe50f7a
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+10_avoid_warning_because_missing_space_between_literal_and_string_macro.patch
--
2.35.1
