Control: tags -1 + patch

Hi Antonio,

* Antonio Valentino <[email protected]> [2022-12-02 07:56]:
We are in the transition of adding python3.11 as a supported Python version [0]. With a recent upload of python3-defaults the autopkgtest of zfp fails in testing when that autopkgtest is run with the binary packages of python3-defaults from unstable. It passes when run with only packages from testing. In tabular form:

                       pass            fail
python3-defaults       from testing    3.10.6-3
zfp                    from testing    1.0.0-3
all others             from testing    from testing

I copied some of the output at the bottom of this report.

Currently this regression is blocking the migration of python3-defaults to testing [1]. https://docs.python.org/3/whatsnew/3.11.html lists what's new in Python3.11, it may help to identify what needs to be updated.

More information about this bug and the reason for filing it can be found on
https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation

Paul

[0] https://bugs.debian.org/1021984
[1] https://qa.debian.org/excuses.php?package=python3-defaults

https://ci.debian.net/data/autopkgtest/testing/amd64/z/zfp/28796454/log.gz

Testing with python3.11:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'zfpy'
autopkgtest [01:18:36]: test autodep8-python3


the problem is due to the fact that out d/rules only build builds the Python extension for the default python version (3.10 currently). IMHO the solution is configure/build twice with cmake in order to have the Python extension for all the supported Python versions.

If it is OK for you, I plan to work on it during the weekend.
If you have an better solution or can point me to a package that faced the same issue please let me know.

pybuild has support for this, I've attached a patch. Note that There is no need to pass -DCMAKE_BUILD_TYPE=RelWithDebInfo to cmake as debhelper does the right thing already.

Cheers Jochen
From 401c0818741fcccac05c66a899319920fd415194 Mon Sep 17 00:00:00 2001
From: Jochen Sprickerhof <[email protected]>
Date: Fri, 2 Dec 2022 09:52:50 +0100
Subject: [PATCH] Use pybuild to compile for all Python versions

Closes: #1025196
---
 debian/control |  2 +-
 debian/rules   | 13 +++----------
 2 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/debian/control b/debian/control
index b06e5d4..185b380 100644
--- a/debian/control
+++ b/debian/control
@@ -12,7 +12,7 @@ Build-Depends:
  cython3,
  gfortran,
  dh-python,
- libpython3-dev,
+ libpython3-all-dev,
  pkg-kde-tools,
  python3-numpy,
  python3-setuptools,
diff --git a/debian/rules b/debian/rules
index c5428e1..55c2888 100755
--- a/debian/rules
+++ b/debian/rules
@@ -13,18 +13,11 @@ export DEB_CFLAGS_MAINT_APPEND  = -Wall -pedantic
 # Package maintainers to append LDFLAGS.
 #export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
 
-export PYBUILD_NAME=zfpy
+export PYBUILD_CONFIGURE_ARGS=-DBUILD_ZFORP=ON -DBUILD_ZFPY=ON -DZFP_BUILD_TESTING_SMALL=OFF -DZFP_BIT_STREAM_WORD_SIZE=8
+export PYBUILD_SYSTEM=cmake
 
 %:
-	dh $@ --with python3,pkgkde_symbolshelper --buildsystem=cmake
-
-override_dh_auto_configure:
-	dh_auto_configure -- \
-	-DBUILD_ZFORP=ON \
-	-DBUILD_ZFPY=ON \
-	-DZFP_BUILD_TESTING_SMALL=OFF \
-	-DZFP_BIT_STREAM_WORD_SIZE=8 \
-	-DCMAKE_BUILD_TYPE=RelWithDebInfo
+	dh $@ --with python3,pkgkde_symbolshelper --buildsystem=pybuild
 
 override_dh_dwz:
 	@echo "BYE DWZ"
-- 
2.38.1

Attachment: signature.asc
Description: PGP signature

Reply via email to