Source: debci
Version: 3.5.2+nmu1
Severity: important
Tags: upstream patch

Dear Maintainer,

Requested tests via Self Service fail to use multiple pinned packaged from the 
same suite.


This job failed because it only used libgdal-grass from unstable:

 https://ci.debian.net/user/sebastic/retry/28928121

 Package name:          libgdal-grass
 Suite and Arch:        testing/amd64
 Trigger:               grass/8.2.0-3 libgdal-grass/1:1.0.2-3
 Pinned packages:       ["src:grass", "src:libgdal-grass", "unstable"]
 Extra APT Sources:     —

From the log: 
https://ci.debian.net/data/autopkgtest/testing/amd64/libg/libgdal-grass/28928112/log.gz

 Get:141 http://deb.debian.org/debian testing/main amd64 grass-core amd64 
8.2.0-2+b1 [6,184 kB]
 Get:142 http://deb.debian.org/debian unstable/main amd64 libgdal-grass amd64 
1:1.0.2-3 [31.1 kB]


This job succeeded, but failed to use both libgdal-grass and grass from 
unstable:


 https://ci.debian.net/user/sebastic/retry/28928134

 Package name:          libgdal-grass
 Suite and Arch:        testing/amd64
 Trigger:               libgdal-grass/1:1.0.2-3 grass/8.2.0-3
 Pinned packages:       ["src:libgdal-grass", "src:grass", "unstable"]
 Extra APT Sources:     —

From the log: 
https://ci.debian.net/data/autopkgtest/testing/amd64/libg/libgdal-grass/28928134/log.gz

 Get:132 http://deb.debian.org/debian testing/main amd64 grass-core amd64 
8.2.0-2+b1 [6,184 kB]
 Get:133 http://deb.debian.org/debian testing/main amd64 libgdal-grass amd64 
1:1.0.2-2+b1 [31.3 kB]


This job succeeded and used both libgdal-grass and grass from unstable, because 
the JSON was manually crafted:

 https://ci.debian.net/user/sebastic/retry/28930518

 Package name:          libgdal-grass
 Suite and Arch:        testing/amd64
 Trigger:               grass/8.2.0-3 libgdal-grass/1:1.0.2-3
 Pinned packages:       ["src:grass,src:libgdal-grass", "unstable"]
 Extra APT Sources:     —

From the log: 
https://ci.debian.net/data/autopkgtest/testing/amd64/libg/libgdal-grass/28930518/log.gz

 Get:133 http://deb.debian.org/debian unstable/main amd64 grass-core amd64 
8.2.0-3 [6,183 kB]
 Get:134 http://deb.debian.org/debian unstable/main amd64 libgdal-grass amd64 
1:1.0.2-3 [31.1 kB]

Note the single string for both packages from unstable.


The following patch might fix the issue:

diff --git a/lib/debci/self_service.rb b/lib/debci/self_service.rb
index 62a706e..26bfc0a 100644
--- a/lib/debci/self_service.rb
+++ b/lib/debci/self_service.rb
@@ -109,7 +109,7 @@ module Debci
         }
         test_obj['pin-packages'] = []
         pin_packages.each do |pin_package|
-          pin_package = pin_package.split(/,\s*/)
+          pin_package = pin_package.split(/,\s+/)
           test_obj['pin-packages'].push(pin_package)
         end
         test_request = {
diff --git a/spec/debci/self_service_spec.rb b/spec/debci/self_service_spec.rb
index 5a4c62f..16a844f 100644
--- a/spec/debci/self_service_spec.rb
+++ b/spec/debci/self_service_spec.rb
@@ -194,7 +194,7 @@ describe Debci::SelfService do
             {
               "trigger": "testing",
               "package": "autodep8",
-              "pin-packages": [["src:bar", "unstable"], ["foo", "src:bar", 
"stable"]],
+              "pin-packages": [["src:bar", "unstable"], ["foo,src:bar", 
"stable"]],
               "is_private": true,
               "extra_apt_sources": ["bullseye-fasttrack"]
             }
@@ -226,7 +226,7 @@ describe Debci::SelfService do
             {
               "trigger": "testing",
               "package": "autodep8",
-              "pin-packages": [["src:bar", "unstable"], ["foo", "src:bar", 
"stable"]]
+              "pin-packages": [["src:bar", "unstable"], ["foo,src:bar", 
"stable"]]
             }
           ]
         }
@@ -248,7 +248,7 @@ describe Debci::SelfService do
             {
               "trigger": "testing",
               "package": "autodep8",
-              "pin-packages": [["src:bar", "unstable"], ["foo", "src:bar", 
"stable"]]
+              "pin-packages": [["src:bar", "unstable"], ["foo,src:bar", 
"stable"]]
             }
           ]
         }
@@ -268,7 +268,7 @@ describe Debci::SelfService do
             {
               "trigger": "testing",
               "package": "autodep8",
-              "pin-packages": [["src:bar", "unstable"], ["foo", "src:bar", 
"stable"]]
+              "pin-packages": [["src:bar", "unstable"], ["foo,src:bar", 
"stable"]]
             }
           ]
         }
@@ -289,7 +289,7 @@ describe Debci::SelfService do
             {
               "trigger": "testing",
               "package": "autodep8",
-              "pin-packages": [["src:bar", "unstable"], ["foo", "src:bar", 
"stable"]],
+              "pin-packages": [["src:bar", "unstable"], ["foo,src:bar", 
"stable"]],
             }
           ]
         }


Kind Regards,

Bas

Reply via email to