On 2022-12-07, Vagrant Cascadian wrote: > On 2019-12-18, Andrei POPESCU wrote: >> Attached patch fixes some issues reported by shellcheck > > Thanks for the patch! > > I will try and merge some of the changes...
Actually, most of the changes appear to be merged already.
>> as well as make some minor optimizations (use bash code instead of
>> external programs where this makes sense).
>
> This is not bash code though, so the bashisms are not appropriate...
It *was* originally bash code, but switched more recently to /bin/sh...
>> @@ -202,12 +202,12 @@ label l${_NUMBER}r
>> linux ${_BOOT_DIRECTORY}/${_KERNEL}
>> ${_INITRD}
>> ${_FDT}
>> - append ${U_BOOT_ROOT} $(echo ${U_BOOT_PARAMETERS} | sed -e 's|
>> quiet||') single
>> + append ${U_BOOT_ROOT} ${U_BOOT_PARAMETERS# quiet} single
>
> Will have to take another look at this one, but it sure *looks*
> cleaner. :)
This seems to be the only thing outstanding... which I'll try to
remember to test.
live well,
vagrant
signature.asc
Description: PGP signature
