Thanks for taking a look at this, Étienne.
On 1/15/23 11:16, Étienne Mollier wrote:
Not sure it will help, but I suppose I could first bump the
rocrand package up to 5.2.3 to be consistent with the build
chain. It should still be easy to do while we're not in the
next stage of the freeze on February 12th.
I would not worry too much about exactly matching the HIP version,
though. While rocrand 5.3 was in development, the hip 5.3 library didn't
exist. The upstream developers would have been building and testing on
hip 5.2 (or earlier) during most of the development cycle.
IMO, it's perfectly fine to update to any version of rocrand that passes
its test suite. My suggestion is 5.3.3, since it matches the other
mathlibs in Debian, but 5.4.2 would also be fine and 5.2.3 could
probably be made to work with minor patches.
The upstream hipRAND repo does't have any tags (and therefore getting tarballs
with uscan might be tricky?). If tags would help, I can work with upstream to
get them added retroactively for rocm-5.1.0 and later. Just let me know.
For a regular package it would be possible to use git commit IDs
instead, but that leads to hard to read version numbers. In the
case of MUT, strolling through the example from rocm-hipamd, I
see it may be necessary to restrict the version number of the
side tarball to be the same as the main source package. So...
yes please? :)
The tags have now been added to hipRAND.
https://github.com/ROCmSoftwarePlatform/hipRAND/tags
Sincerely,
Cory Bloor
