Hi, Sorry it took so long.
On 02-01-2022 01:43, Iain Lane wrote:
On Sat, Jan 01, 2022 at 10:05:21PM +0100, Paul Gevers wrote:Hi Raphael, On 01-01-2022 21:37, Raphael Hertzog wrote:On Fri, 31 Dec 2021, Paul Gevers wrote:Otherwise I would like to suggest to create two entries, one with "Pin: release a=foo" and one with "Pin: release n=foo" so that we are sure to match on any of the 3 fields.I'll have to check and think about this. I remember that I had lots of issues with coming up with changes to autopkgtest that also worked for Ubuntu, as they use the same Codename for the real Suite and the *-proposed Suite (which they call pocket). I don't recall if that was with respect to pinning or other aspects of autopkgtest and it's requirement to manipulate where packages should be installed from. Before committing your proposal I need to understand that I'm not breaking existing valid configurations too.I saw a comment mentionning this, but it was related to the "--apt-pocket" option and I didn't change that part, which still uses the "a=foo" syntax. https://salsa.debian.org/ci-team/autopkgtest/-/blob/master/lib/adt_testbed.py#L1263Right, thanks for referencing that line as it has the bug number where the relevant information was. As the --pin-packages option will already have the *-pocket in the name, I think this would work for Ubuntu too. CC-ing Iain for a sanity check on our reasoning.Thanks for copying me on this. Julian might be a good one also.
Done now.
I fear I've probably forgotten most of these details, so please pardon me for this response… Wasn't the problem for Ubuntu that 'Pin: release foo' also applies to foo-proposed too? I think 'Pin: release foo-proposed' will work as intended though, right? Is the latter what we'll start generating with this? Seeing some example generated pins (before / after the patch) would be great to help reason about this.
The patch also removes the "a=" from the pinning for the default release (at 990) and I think that will break Ubuntu's setup as the packages from the proposed pocket will suddenly satisfy this pin too. What you (Iain) discussed above works for the pocket/foo-proposed part, but I think Raphael needs the other part too. I fear that without additional options, we can't really fix this.
I guess a test covering this for all of the Ubuntu, Debian & Kali cases would be helpful in terms of confidence both with this change and making any future changes here. The one thing I do remember is that it's hairy, like all the pinning stuff in autopkgtest. :-)
Yes. In the same area; for Debian I once had a proposal to set the Default-Release instead of using the pinning, but that broke Ubuntu's case. It would have reduced another hairy part of autopkgtest tremendously, where a lot of sed/awk/grep-ing happens in the testbed to figure out which version of the source to install for the test. But alas, autopkgtest needs to support the Ubuntu archive.
Paul
OpenPGP_signature
Description: OpenPGP digital signature
