* FC Stegerman <f...@obfusk.net> [2023-02-03 17:58]:
> * Andreas Tille <andr...@an3as.eu> [2023-02-03 17:01]:
> > I've bumped upstream version to 1.12.3 which basically has the
> > suggested patches applied but the issue remains as you can see
> > in Salsa CI
> > 
> >    https://salsa.debian.org/science-team/python-param/-/jobs/3891083
> > 
> > Do you have any further hints?
> 
> That looks like a different issue: get_setup_version() in setup.py
> seems to be trying to get the version from git, which of course fails
> when building the Debian package without the .git directory present.
> 
> Presumably there is a way to get the version from e.g.
> "dpkg-parsechangelog -S Version" (minus the -1 revision) instead.  I'm
> not sure how other packages handle this.

Again, I'm not sure what is considered best practice here, but
something like this should work:

adding this to debian/rules

  export PARAM_PACKAGE_VERSION := $(shell dpkg-parsechangelog -S Version)

and patching setup.py to change

  def get_setup_version(reponame):
      """Use autover to get up to date version."""
      # importing self into setup.py is unorthodox, but param has no
      # required dependencies outside of python
      from param.version import Version
      return 
Version.setup_version(os.path.dirname(__file__),reponame,archive_commit="$Format:%h$")

to e.g.

  def get_setup_version(reponame):
      """Use autover to get up to date version."""
      if version := os.environ.get("PARAM_PACKAGE_VERSION"):
          return version.split("-", 1)[0]
      # importing self into setup.py is unorthodox, but param has no
      # required dependencies outside of python
      from param.version import Version
      return 
Version.setup_version(os.path.dirname(__file__),reponame,archive_commit="$Format:%h$")

- FC

Reply via email to