I think I got the code to detect if IPv6 is available to work correctly
so I could set the DISABLE_IPV6 environment variable that
dask.distrubted supports.
This probably refers to
https://salsa.debian.org/python-team/packages/dask.distributed/-/blob/debian/master/debian/tests/run-tests#L11
This doesn't work: because run-tests is set -e, failing this check
immediately ends the autopkgtest with failure (without even running the
main tests):
https://salsa.debian.org/python-team/packages/dask.distributed/-/jobs/3918057
I think you instead need the command inside the if-test, something like
if ip -6 addr | grep global ; then
if ping6 -c 4 2001:4860:4860::8888 ; then
echo "Working ipv6 connectivity"
but I haven't tested that.
I went with skipping the 32bit tests instead of xfailed because I don't
think they can work as written since I really think they're making
really large memory requests that can't ever succeed on 32bit.
Agreed - I'm possibly in the habit of using xfail rather than skip
because I'm often xfailing the kind of things that might get fixed later.
You did a lot of work on trying to get the flaky tests to work more
reliably, and all that's included.
https://salsa.debian.org/rnpalmer-guest/dask.distributed/-/commit/b82894aa5247cd11607b177d60975387c2fd796a
(marking a few more tests as flaky) isn't included. However as
previously mentioned, I don't claim to know whether we actually should
be marking those particular tests as flaky, so it's fine to omit that
one if you think we shouldn't.
Also as previously mentioned, test_balance_expensive_tasks[enough work
to steal] seems to fail repeatedly when it fails, so if we want to
ignore that (again, I don't claim to know whether that's a good idea),
it needs an xfail/skip not just a flaky.
