Hi Jeremy, On Fri, Feb 24, 2023 at 10:01:09AM -0500, Jeremy Bícha wrote: > This change seems to cause the package to fail the build. Before your > change, this is a build warning not an error.
This is due to improperly combining the new version with my patch. Patching the reported version works. > dh_auto_build -- CC=valac > make -j8 "INSTALL=install --strip-program=true" CC=valac > make[2]: Entering directory '/<<PKGBUILDDIR>>' > valac --pkg folks aggregate-avatars.vala > aggregate-avatars.vala:53.3-53.41: warning: unhandled error `GLib.Error' > 53 | cache_dir.make_directory_with_parents(); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Unknown option -I/usr/include/glib-2.0 > Run 'valac --help' to see a full list of available command line options. > error: cc exited with status 256 > Compilation failed: 1 error(s), 1 warning(s) At this time, the Makefile stuffs compiler flags into the CC variable. Passing CC, overrides them and they thus get lost. Please separate them out of CC. Helmut
