On 2023-03-11 14:39, Alejandro Colomar wrote:
I wonder if the patch is really "simplifying".
It depends on how one measures simplicity. The reader will need to know strftime's API regardless; requiring the reader to also know strlcpy's API makes the reader's job harder.
Also, it's less machine code to call just the one function (if one cares about simplicity of debugging :-).
If you still prefer calling two different functions instead of just one, feel free to modify it to use plain strcpy. strlcpy isn't needed here as the destination buffers are all big enough. To be honest though I like it the way it is (though it could use a comment; I'll add that).
