On Sat, 01 Apr 2023 20:37:55 +0100 "Adam D. Barratt" <a...@adam-barratt.org.uk> wrote:
>Control: tags -1 + moreinfo > >On Wed, 2023-01-18 at 15:13 +0100, Andreas Rönnquist wrote: >> The clutter library is buggy, to the extent that geeqie might crash >> if >> not ran without it. This fix simply removes the libchamplain >> dependency >> (which in it's turn depends on clutter). This makes it possible and >> easier to run geeqie without the need for the cli --disable-clutter >> argument. (Fixes #1027753 [1], and please also see #1018123 [2]) >> >> > >Apologies for the delay in getting back to you on this. > >Presumably geeqie doesn't actually use libchamplain? If so, why does it >depend on it to begin with? > It does use it - If you go to the menu - View > Info Sidebar, (Ctrl+K might be the keyboard shortcut) - and there select the "Add Pane" button (In my GTK theme it's simply a plus sign), and there you can select "GPS Map". (This is on the version in stable, but not on testing/unstable). Then you can drag images to a position on the map to set the GPS coordinates for images. Without libchamplain you have to enter GPS coordinates manually, which of course is way more unintuitive. - but it can still be done. Libchamplain is dependant on clutter - and clutter is going into retirement mode upstream (see https://blogs.gnome.org/clutter/ ). I believe the functionality of libchamplain/clutter in geeqie might be re-added using the methods mentioned there sooner or later - GTK4 and libadwaita. Sure, it's a feature that gets dropped, but i find this preferable to having it not working on remote X (as in #1027753 - [1]). The clutter support has also been removed in unstable, as you can see in the other bug (#1018123 -[2]). >Looking at the diff, I think the change is actually the removal of a >/build/ dependency, not a runtime one? If so, it would be good if that >were slightly clearly in the changelog. > Sure, Updated diff attached. thanks /Andreas 1: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027753 2: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1018123
diff -Nru geeqie-1.6/debian/changelog geeqie-1.6/debian/changelog --- geeqie-1.6/debian/changelog 2022-03-23 11:40:44.000000000 +0100 +++ geeqie-1.6/debian/changelog 2023-01-18 14:00:45.000000000 +0100 @@ -1,3 +1,10 @@ +geeqie (1:1.6-9+deb11u2) bullseye; urgency=medium + + * Remove build dependency on libchamplain, disables clutter + support - fixes running via remote X (Closes: #1027753) + + -- Andreas Rönnquist <gus...@debian.org> Wed, 18 Jan 2023 14:00:45 +0100 + geeqie (1:1.6-9+deb11u1) bullseye; urgency=medium * Add patch to fix Ctrl click inside of a block selection diff -Nru geeqie-1.6/debian/control geeqie-1.6/debian/control --- geeqie-1.6/debian/control 2022-03-23 11:40:44.000000000 +0100 +++ geeqie-1.6/debian/control 2023-01-17 20:21:27.000000000 +0100 @@ -20,7 +20,6 @@ libwebp-dev, libdjvulibre-dev, libopenjp2-7-dev, - libchamplain-gtk-0.12-dev, libpoppler-glib-dev, yelp-tools Build-Conflicts: libexiv2-dev (= 0.19-2)