I'm AFK this week so won't be able to do an upload either. I agree that putting the unit files where systemd.pc says they should go is probably the right thing to do. However it feels nonsensical to move files from /usr/lib to /lib only so they can be moved back by the /usr-merge; reading #1031695 I don't see anybody saying this is a sensible thing to do...
I think we should take a step back and think about how a freshly installed mpd package should look like. I think it may actually be a feature that the system mpd.service is not enabled and started on a fresh install. On most desktop/laptop machines, leaving the system service off and enabling the user service is probably the better thing to do. How long has dh-installsystemd been disregarding our unit files? We may want to add --no-enable when we apply that patch. So I think in the case of mpd, perhaps nothing is severely broken currently and this bug doesn't require fixing for bookworm. Instead, it can perhaps be downgraded and fixed with the next regular upload, after the release? (In addition to fresh installs, we may also want to think about upgrades - do running daemons get restarted? Also in the --user case?) Florian Am 11. April 2023 21:01:02 MESZ schrieb Geoffroy Youri Berret <kal...@debian.org>: >On 4/11/23 17:57, Max Kellermann wrote: >> On 2023/04/11 17:40, Andreas Henriksson <andr...@fatal.se> wrote: >>> I think 2 is better myself and I'm attaching a proof of concept >>> debdiff to implement it. (You might want to make a cleaner version.) >> >> Agree. I think your patch looks quite clean, and if it were submitted >> to me, I'd merge it (the same would probably be necessary for the user >> units). > >Here is an updated version (with user unit patch). > >I did not get through all the thread in #1031695 then I'm not sure about user >unit location, but relying on systemd.pc ship them in /usr/lib/systemd/user/, >hopes it's fine. > >Please review, I'm not super confident with my meson expertise. > >I wont be able push these changes until next week, then please go ahead if >needed. > >Cheers, >k
