Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: linphone-desk...@packages.debian.org
Control: affects -1 + src:linphone-desktop

Please unblock package linphone-desktop

[ Reason ]
It fixes the RC bug #1033868 where you had to agree to the upstream's ToS and
privacy policy even if not using their SIP service. This has been fixed by
Dennis by backporting a patch that has been in experimental for quite some
time (but linphone 5.0 did not make the freeze)

[ Impact ]
RC bug is not fixed

[ Tests ]
Testing done by the maintainer

[ Risks ]
Code change is trivial

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

unblock linphone-desktop/4.4.10-3
diff -Nru linphone-desktop-4.4.10/debian/changelog 
linphone-desktop-4.4.10/debian/changelog
--- linphone-desktop-4.4.10/debian/changelog    2022-11-27 18:02:24.000000000 
+0100
+++ linphone-desktop-4.4.10/debian/changelog    2023-04-04 18:09:27.000000000 
+0200
@@ -1,3 +1,10 @@
+linphone-desktop (4.4.10-3) unstable; urgency=medium
+
+  * Add patch to relax needlessly strict Terms of Service dialogue
+    (Closes: #1033868).
+
+ -- Dennis Filder <d.fil...@web.de>  Tue, 04 Apr 2023 18:09:27 +0200
+
 linphone-desktop (4.4.10-2) unstable; urgency=medium
 
   * Release to unstable.
diff -Nru 
linphone-desktop-4.4.10/debian/patches/adjust-terms-of-service-barrier.patch 
linphone-desktop-4.4.10/debian/patches/adjust-terms-of-service-barrier.patch
--- 
linphone-desktop-4.4.10/debian/patches/adjust-terms-of-service-barrier.patch    
    1970-01-01 01:00:00.000000000 +0100
+++ 
linphone-desktop-4.4.10/debian/patches/adjust-terms-of-service-barrier.patch    
    2023-04-04 18:09:27.000000000 +0200
@@ -0,0 +1,25 @@
+Description: Enable creation of third-party accounts unconditionally
+ Users should be able to do it without the need for accepting BC's
+ Terms of Use and Privacy Policy.
+Author: Dennis Filder <d.fil...@web.de>
+Last-Update: 2022-12-13
+--- a/linphone-app/ui/views/App/Main/Assistant/AssistantHome.qml
++++ b/linphone-app/ui/views/App/Main/Assistant/AssistantHome.qml
+@@ -101,7 +101,7 @@
+               
+               cellHeight: height / 2
+               cellWidth: width / 2
+-              enabled: cguCheckBox.checked
++//            enabled: cguCheckBox.checked
+               
+               delegate: Item {
+                       height: buttons.cellHeight
+@@ -113,7 +113,7 @@
+                                       margins: 
AssistantHomeStyle.buttons.spacing
+                               }
+                               
+-                              enabled: cguCheckBox.checked && 
SettingsModel[$viewType.charAt(0).toLowerCase() + $viewType.slice(1) + 
"Enabled"]
++                              enabled: $viewType=='UseOtherSipAccount' || 
(cguCheckBox.checked && SettingsModel[$viewType.charAt(0).toLowerCase() + 
$viewType.slice(1) + "Enabled"])
+                               text: $text.replace('%1', 
Qt.application.name.toUpperCase())
+                               
+                               onClicked:{ assistant.pushView($view, $props) }
diff -Nru linphone-desktop-4.4.10/debian/patches/series 
linphone-desktop-4.4.10/debian/patches/series
--- linphone-desktop-4.4.10/debian/patches/series       2022-11-27 
18:02:24.000000000 +0100
+++ linphone-desktop-4.4.10/debian/patches/series       2023-04-04 
18:09:27.000000000 +0200
@@ -5,3 +5,4 @@
 louden-find-package.patch
 guard-codec-download.patch
 #a11y.patch
+adjust-terms-of-service-barrier.patch

Reply via email to