Control: tags -1 + moreinfo
On 5/9/23 16:13, Andreas Beckmann wrote:
Package: node-source-map
Version: 0.7.0++dfsg2+really.0.6.1-13
Severity: serious
User: debian...@lists.debian.org
Usertags: piuparts
Hi,
a test with piuparts revealed that your package misses the copyright
file after an upgrade, which is a violation of Policy 12.5:
https://www.debian.org/doc/debian-policy/ch-docs.html#copyright-information
After the upgrade /usr/share/doc/$PACKAGE/ is just an empty directory.
This was observed on the following upgrade paths:
bullseye -> bookworm
From the attached log (scroll to the bottom...):
0m39.3s ERROR: WARN: Inadequate results from running adequate!
node-source-map: broken-symlink /usr/share/doc/node-source-map ->
../libjs-source-map
node-source-map: missing-copyright-file
/usr/share/doc/node-source-map/copyright
Hi,
node-source-map depends on libjs-source-map, so the link isn't broken in
normal installation.
Regards,
Yadd
MISSING COPYRIGHT FILE: /usr/share/doc/node-source-map/copyright
# ls -lad /usr/share/doc/node-source-map
lrwxrwxrwx 1 root root 19 May 3 22:16 /usr/share/doc/node-source-map ->
../libjs-source-map
# ls -la /usr/share/doc/node-source-map/
ls: cannot access '/usr/share/doc/node-source-map/': No such file or
directory
Additional info may be available here:
https://wiki.debian.org/MissingCopyrightFile
Note that dpkg intentionally does not replace directories with symlinks
and vice versa, you need the maintainer scripts to do this.
See in particular the end of point 4 in
https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#details-of-unpack-phase-of-installation-or-upgrade
It is recommended to use the dpkg-maintscript-helper commands
'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.14)
to perform the conversion, ideally using d/$PACKAGE.maintscript.
See dpkg-maintscript-helper(1) and dh_installdeb(1) for details.
cheers,
Andreas
