Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
Please unblock package gosa-plugins-systems
This upload fixes piuparts upgrade tests + PHP 8.2 deprecation warnings.
[ Reason ]
+ * debian/control:
+ + Add more B:/R: relations to old GOsa² 2.7.x packages which this package
+ replaces. (Closes: #1034967).
-> Fix upgrade path from src:gosa 2.7 to src:gosa 2.8 (see referenced bug
report with
installation problems that have been resolved in this upload).
+ * debian/patches:
+ + Add 1001_php8.2-deprecations.patch. Amend various PHP 8.2 deprecations.
-> While at it, include various PHP 8.2 deprecation warnings that have
been spotted over the past weeks.
[ Impact ]
Resolves piupart upgrade test, fixes PHP warnings being displayed on
screen with previous versions of this package.
[ Tests ]
Manual tests, piuparts seems to be happy now.
[ Risks ]
Problems introduced by this upload will only affect GOsa² (src:pkg gosa).
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
[ Other info ]
There are likely more PHP 8.2 issues which I might only be able to
address as 12.x point release update.
unblock gosa-plugins-systems/2.8~git20211027.5741b8f-4
diff -Nru gosa-plugins-systems-2.8~git20211027.5741b8f/debian/changelog
gosa-plugins-systems-2.8~git20211027.5741b8f/debian/changelog
--- gosa-plugins-systems-2.8~git20211027.5741b8f/debian/changelog
2023-02-06 20:56:57.000000000 +0100
+++ gosa-plugins-systems-2.8~git20211027.5741b8f/debian/changelog
2023-05-16 23:10:07.000000000 +0200
@@ -1,3 +1,13 @@
+gosa-plugins-systems (2.8~git20211027.5741b8f-4) unstable; urgency=medium
+
+ * debian/control:
+ + Add more B:/R: relations to old GOsa² 2.7.x packages which this package
+ replaces. (Closes: #1034967).
+ * debian/patches:
+ + Add 1001_php8.2-deprecations.patch. Amend various PHP 8.2 deprecations.
+
+ -- Mike Gabriel <sunwea...@debian.org> Tue, 16 May 2023 23:10:07 +0200
+
gosa-plugins-systems (2.8~git20211027.5741b8f-3) unstable; urgency=medium
[ Daniel Teichmann ]
diff -Nru gosa-plugins-systems-2.8~git20211027.5741b8f/debian/control
gosa-plugins-systems-2.8~git20211027.5741b8f/debian/control
--- gosa-plugins-systems-2.8~git20211027.5741b8f/debian/control 2023-02-06
20:55:55.000000000 +0100
+++ gosa-plugins-systems-2.8~git20211027.5741b8f/debian/control 2023-05-16
23:08:28.000000000 +0200
@@ -22,13 +22,19 @@
gosa-plugin-systems (<< 2.8~),
gosa-plugin-dns (<< 2.8~),
gosa-plugin-dhcp (<< 2.8~),
+ gosa-plugin-gofax (<< 2.8~),
gosa-plugin-goto (<< 2.8~),
+ gosa-plugin-mail (<< 2.8~),
+ gosa-plugin-rsyslog (<< 2.8~),
gosa-plugins-goto,
Replaces:
gosa-plugin-systems (<< 2.8~),
gosa-plugin-dns (<< 2.8~),
gosa-plugin-dhcp (<< 2.8~),
+ gosa-plugin-gofax (<< 2.8~),
gosa-plugin-goto (<< 2.8~),
+ gosa-plugin-mail (<< 2.8~),
+ gosa-plugin-rsyslog (<< 2.8~),
gosa-plugins-goto,
Provides:
gosa-plugin-systems,
diff -Nru
gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/1001_php8.2-deprecations.patch
gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/1001_php8.2-deprecations.patch
---
gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/1001_php8.2-deprecations.patch
1970-01-01 01:00:00.000000000 +0100
+++
gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/1001_php8.2-deprecations.patch
2023-03-17 12:05:45.000000000 +0100
@@ -0,0 +1,99 @@
+--- a/admin/systems/services/dhcp/class_servDHCP.inc
++++ b/admin/systems/services/dhcp/class_servDHCP.inc
+@@ -1,5 +1,6 @@
+ <?php
+
++#[\AllowDynamicProperties]
+ class servdhcp extends goService
+ {
+ /* attribute list for save action */
+--- a/admin/systems/services/dns/class_servDNSeditZone.inc
++++ b/admin/systems/services/dns/class_servDNSeditZone.inc
+@@ -1,5 +1,6 @@
+ <?php
+
++#[\AllowDynamicProperties]
+ class servdnseditZone extends plugin
+ {
+ /* attribute list for save action */
+@@ -48,6 +49,8 @@
+ /* All types with required attrs */
+ $this->RecordTypes = DNS::getDnsRecordTypes(true);
+
++ $attrs = is_null($attrs) ? array() : $attrs;
++
+ if(!count($attrs)){
+ $this->OldZoneName = "";
+ $this->OldReverseZone = "";
+--- a/admin/systems/services/kolab/class_servKolab.inc
++++ b/admin/systems/services/kolab/class_servKolab.inc
+@@ -1,5 +1,6 @@
+ <?php
+
++#[\AllowDynamicProperties]
+ class servkolab extends goService
+ {
+ var $postfix_mydomain = "";
+--- a/admin/systems/services/mail/class_goMailServer.inc
++++ b/admin/systems/services/mail/class_goMailServer.inc
+@@ -1,5 +1,6 @@
+ <?php
+
++#[\AllowDynamicProperties]
+ class goMailServer extends goService{
+
+ var $cli_summary = "This pluign is used within the ServerService
Pluign \nand indicates that this server supports mailqueue listings and so on.";
+--- a/admin/systems/services/spam/class_goSpamServer.inc
++++ b/admin/systems/services/spam/class_goSpamServer.inc
+@@ -1,5 +1,6 @@
+ <?php
+
++#[\AllowDynamicProperties]
+ class gospamserver extends goService{
+
+ /* This plugin only writes its objectClass */
+--- a/admin/systems/services/terminal/class_goTerminalServer.inc
++++ b/admin/systems/services/terminal/class_goTerminalServer.inc
+@@ -1,5 +1,6 @@
+ <?php
+
++#[\AllowDynamicProperties]
+ class goTerminalServer extends goService{
+
+ /* This plugin only writes its objectClass */
+--- a/admin/systems/goto/tabs_workstation.inc
++++ b/admin/systems/goto/tabs_workstation.inc
+@@ -1,5 +1,6 @@
+ <?php
+
++#[\AllowDynamicProperties]
+ class worktabs extends tabs
+ {
+
+@@ -7,7 +8,7 @@
+
+ function __construct($config, $data, $dn,$category,$hide_refs = FALSE,
$hide_acls = FALSE)
+ {
+-
++
+ /* Save dn */
+ $this->dn= $dn;
+ $this->config= $config;
+--- a/admin/systems/services/dns/class_servDNS.inc
++++ b/admin/systems/services/dns/class_servDNS.inc
+@@ -1,5 +1,6 @@
+ <?php
+
++#[\AllowDynamicProperties]
+ class servdns extends goService
+ {
+ /* attribute list for save action */
+--- a/admin/systems/services/kiosk/class_goKioskService.inc
++++ b/admin/systems/services/kiosk/class_goKioskService.inc
+@@ -1,5 +1,6 @@
+ <?php
+
++#[\AllowDynamicProperties]
+ class goKioskService extends goService{
+
+ /* This plugin only writes its objectClass */
diff -Nru gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/series
gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/series
--- gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/series
2023-02-06 20:53:02.000000000 +0100
+++ gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/series
2023-03-17 11:41:14.000000000 +0100
@@ -2,3 +2,4 @@
0002_add-dnszone-schema.patch
0003_add-dhcp-schema.patch
0004_integrate-goto-plugin-code.patch
+1001_php8.2-deprecations.patch
