On Thu, 18 May 2023 09:00:03 +0200, Lucas Nussbaum wrote:

> During a rebuild of all packages in testing (bookworm), your package failed
> to build on amd64.
> 
> 
> Relevant part (hopefully):
> >  debian/rules binary
> > dh binary
> >    dh_update_autotools_config
> >    dh_autoreconf
> >    debian/rules execute_before_dh_auto_configure
> > make[1]: Entering directory '/<<PKGBUILDDIR>>'
> > # Fail the build if the tzdata package does not match TZVER.
> > grep -q '^# version 2022g$' /usr/share/zoneinfo/tzdata.zi
> > make[1]: *** [debian/rules:28: execute_before_dh_auto_configure] Error 1

This looked reasonably easy to fix (cf. attached patch), but the
tests fail as follows:

#v+
Running "nodeunit:countries" (nodeunit) task
Testing countries.jsFF
>> countries - zone_countries
>> Error: [] deepEqual [ 'CA' ]
>> at Object.deepEqual (/usr/share/nodejs/nodeunit/lib/types.js:83:39)
>> at Object.zone_countries (tests/countries/countries.js:230:8)
>> at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
>> at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
>> at /usr/share/nodejs/nodeunit/lib/core.js:236:16
>> at Object.exports.runTest (/usr/share/nodejs/nodeunit/lib/core.js:70:9)
>> at /usr/share/nodejs/nodeunit/lib/core.js:118:25
>> at /usr/share/javascript/async/async.js:665:13
>> at iterate (/usr/share/javascript/async/async.js:149:13)
>> at async.eachSeries (/usr/share/javascript/async/async.js:165:9)

>> countries - zone_countries
>> Error: [ 'US' ] deepEqual [ 'UM', 'US' ]
>> at Object.deepEqual (/usr/share/nodejs/nodeunit/lib/types.js:83:39)
>> at Object.zone_countries (tests/countries/countries.js:552:8)
>> at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
>> at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
>> at /usr/share/nodejs/nodeunit/lib/core.js:236:16
>> at Object.exports.runTest (/usr/share/nodejs/nodeunit/lib/core.js:70:9)
>> at /usr/share/nodejs/nodeunit/lib/core.js:118:25
>> at /usr/share/javascript/async/async.js:665:13
>> at iterate (/usr/share/javascript/async/async.js:149:13)
>> at async.eachSeries (/usr/share/javascript/async/async.js:165:9)

>> countries - country_zones
>> Actual:
>>   [
>>     'America/Atikokan',      'America/Blanc-Sablon',
>>     'America/Cambridge_Bay', 'America/Creston',
>>     'America/Dawson',        'America/Dawson_Creek',
>>     'America/Edmonton',      'America/Fort_Nelson',
>>     'America/Glace_Bay',     'America/Goose_Bay',
>>     'America/Halifax',       'America/Inuvik',
>>     'America/Iqaluit',       'America/Moncton',
>>     'America/Panama',        'America/Phoenix',
>>     'America/Puerto_Rico',   'America/Rankin_Inlet',
>>     'America/Regina',        'America/Resolute',
>>     'America/St_Johns',      'America/Swift_Current',
>>     'America/Toronto',       'America/Vancouver',
>>     'America/Whitehorse',    'America/Winnipeg'
>>   ]
>> Operator:
>>   deepEqual
>> Expected:
>>   [
>>     'America/Atikokan',      'America/Blanc-Sablon',
>>     'America/Cambridge_Bay', 'America/Creston',
>>     'America/Dawson',        'America/Dawson_Creek',
>>     'America/Edmonton',      'America/Fort_Nelson',
>>     'America/Glace_Bay',     'America/Goose_Bay',
>>     'America/Halifax',       'America/Inuvik',
>>     'America/Iqaluit',       'America/Moncton',
>>     'America/Panama',        'America/Phoenix',
>>     'America/Puerto_Rico',   'America/Rankin_Inlet',
>>     'America/Regina',        'America/Resolute',
>>     'America/St_Johns',      'America/Swift_Current',
>>     'America/Toronto',       'America/Vancouver',
>>     'America/Whitehorse',    'America/Winnipeg',
>>     'America/Yellowknife'
>>   ]
>> at Object.deepEqual (/usr/share/nodejs/nodeunit/lib/types.js:83:39)
>> at Object.country_zones (tests/countries/countries.js:646:8)
>> at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
>> at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
>> at /usr/share/nodejs/nodeunit/lib/core.js:236:16
>> at Object.exports.runTest (/usr/share/nodejs/nodeunit/lib/core.js:70:9)
>> at /usr/share/nodejs/nodeunit/lib/core.js:118:25
>> at /usr/share/javascript/async/async.js:665:13
>> at iterate (/usr/share/javascript/async/async.js:149:13)
>> at /usr/share/javascript/async/async.js:160:25

>> countries - country_zones
>> Actual:
>>   [
>>     'Pacific/Midway',
>>     'Pacific/Pago_Pago',
>>     'Pacific/Tarawa',
>>     'Pacific/Wake'
>>   ]
>> Operator:
>>   deepEqual
>> Expected:
>>   [
>>     'Pacific/Honolulu',
>>     'Pacific/Midway',
>>     'Pacific/Pago_Pago',
>>     'Pacific/Tarawa',
>>     'Pacific/Wake'
>>   ]
>> at Object.deepEqual (/usr/share/nodejs/nodeunit/lib/types.js:83:39)
>> at Object.country_zones (tests/countries/countries.js:839:8)
>> at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
>> at Object.<anonymous> (/usr/share/nodejs/nodeunit/lib/core.js:236:16)
>> at /usr/share/nodejs/nodeunit/lib/core.js:236:16
>> at Object.exports.runTest (/usr/share/nodejs/nodeunit/lib/core.js:70:9)
>> at /usr/share/nodejs/nodeunit/lib/core.js:118:25
>> at /usr/share/javascript/async/async.js:665:13
>> at iterate (/usr/share/javascript/async/async.js:149:13)
>> at /usr/share/javascript/async/async.js:160:25

Warning: 4/841 assertions failed (48ms) Use --force to continue.

Aborted due to warnings.
dh_auto_test: error: /bin/sh -ex debian/tests/pkg-js/test returned exit code 6
make: *** [debian/rules:24: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
#v-

Apparently there's more work needed to adjust the test suite (list of
timezones) to tzdata 2023c …


Cheers,
gregor


-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   
diff -Nru moment-timezone.js-0.5.40+dfsg/debian/changelog moment-timezone.js-0.5.40+dfsg/debian/changelog
--- moment-timezone.js-0.5.40+dfsg/debian/changelog	2023-01-23 22:37:52.000000000 +0100
+++ moment-timezone.js-0.5.40+dfsg/debian/changelog	2023-05-28 17:32:43.000000000 +0200
@@ -1,3 +1,13 @@
+moment-timezone.js (0.5.40+dfsg-1.1+2023c) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix "FTBFS in testing":
+    + d/control: build depend on the tzdata version in bookworm
+    + d/changelog: set version accordingly
+    (Closes: #1036259)
+
+ -- gregor herrmann <gre...@debian.org>  Sun, 28 May 2023 17:32:43 +0200
+
 moment-timezone.js (0.5.40+dfsg-1+2022g) unstable; urgency=medium
 
   * New upstream version 0.5.40. Closes: #1028879.
diff -Nru moment-timezone.js-0.5.40+dfsg/debian/control moment-timezone.js-0.5.40+dfsg/debian/control
--- moment-timezone.js-0.5.40+dfsg/debian/control	2023-01-23 22:37:52.000000000 +0100
+++ moment-timezone.js-0.5.40+dfsg/debian/control	2023-05-28 17:32:43.000000000 +0200
@@ -10,7 +10,7 @@
  , dh-sequence-nodejs
  , uglifyjs
  , ts-node <!nocheck>
- , tzdata (>= 2022f)
+ , tzdata (>= 2023c)
 Standards-Version: 4.6.1
 Vcs-Browser: https://salsa.debian.org/js-team/moment-timezone.js
 Vcs-Git: https://salsa.debian.org/js-team/moment-timezone.js.git

Attachment: signature.asc
Description: Digital Signature

Reply via email to