On Thu, 1 Jun 2023 at 15:48, Theodore Ts'o <ty...@mit.edu> wrote: > > In addition to Bookworm being hard frozen, I question the importance > of this patch, the bug priority, and whether the title is correct. > After all, at least with respect to e2fsprogs systemd unit *will* > still be enabled. It will just be enabled using > ../multi-user.target/wanted instead of ../default.target/wanted. > > Ok, piuparts whines about it, and I agree that it's ideal if things > are the stame regardless of whether the distro is freshly installed or > uprgaded --- but e2scrub-repeat.service will *still* be enabled, > right? And so the bug title is misleaing, right? > > So it's not a big deal; is that correct so this patch is not worth > trying to shoehorn in beform Bookworm ships, and this particular patch > can be safely downgraded from importanted, right?
I think all of that is true, yep. Also, arguing against my own revert-patch: I think it could be said that multi-user is the "better" target to use here, because the default could be "graphical" or some later-reached system state whereas this is a relatively low-level (if small) system cleanup service. It's taken me too long to figure all this out, but retrospectively I suppose my preference order here was: 1. Fix comprehensively in deb-systemd-helper. 2. Revert the original change (but I thought of / suggested that too late). 3. Apply a package-specific workaround (but I didn't find one that I was comfortable with suggesting). I'd agree with downgrading the severity to below RC (and it's your package, so feel free, I think? maybe even close it?). If anyone arrives here/reports other bugs as a result of experiencing it, I think we can let them know that it's safe to remove the legacy 'default.target' symlink (does that sound correct too?). Without getting too much into opinions on systemd itself: I think declarative systems are good, but that managing stateful transitions between multiple declared states can be challenging. Not impossible, and with sufficient bugreporting and fixing, it can be made solid - so that's something to continue on after the release. (and yep, I claimed I wouldn't look at this bug again for a while.. and I was tempted not to.. but I think clearing it from the RC queue is probably worthwhile)
