Source: devscripts
Version: 2.23.5
Severity: serious
Tags: patch ftbfs trixie sid
Justification: fails to build from source (but built successfully in the past)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Since the upload of libgitlab-api-v4-perl 0.27-1, devscripts has test
failures both in autopkgtests and during build, c.f.
https://ci.debian.net/data/autopkgtest/testing/i386/d/devscripts/34359109/log.gz
Undefined subroutine &JSON::to_json called at ./t/salsa.pm line 49.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 1.
t/salsa.t .........
Dubious, test returned 255 (wstat 65280, 0xff00)
All 1 subtests passed
make[1]: *** [Makefile:44: test_perl.test_installed] Error 1
make: *** [Makefile:47: test-installed] Error 2
The reason is that test/t/salsa.pm calls JSON::to_json without
importing the JSON module (and without a dependency); this has
worked so far because libgitlab-api-v4-perl dependend on and loaded
JSON, but 0.27 has switched to JSON::MaybeXS.
Trivial and tested patch attached.
Cheers,
gregor
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmSPKnZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgZ69BAAlCCHtwE+ZqffD+umkpcPwY9s892wrLhhKCYOqpEWqN+Ykarz6UMjBisH
RubNjUVceR+rsoWUqWcenjvPSTvqU3ctp9FeFAElh9DD161oOogmljqYGovR9ZaA
ZCgNCZcNHuKBVzIScFK8pnI2C4mAq8KHC3US/ewu7cv1U0ijY+N6bJQ7Ge1HiAN8
nRZSEwLFTLZ84GKsm/1nHNrays/2Q6G/QhZr1q0lllLvFQdViv3O8m4Xp76YMNF7
Bk2rcQjHx3q28B5avj4aze+Mx66QCVHKMv7CA7R6RmKvPpMdrdOfTCzwbsydWowc
0Sh7ecrrnCuwSwFyDcofssMwEdDOD3gLvvvDOqcNb6OCxtZYHILhsm+SEA7eNsPK
XRWptGINYKd1lNoY/1mQ1kaj9z6PU++v0skcgnA4NYqcohjKRjtBdLSJUkFH6DRS
4D/CQNtgHYM0yNOqYuZdhTDAZYD4G4YXJWsP6FPRkKnZ8nM4RugWtY05F6Ez4gQ4
IhJ0ousPUiY+G38mIVypdz1PmkMVehhEglyrM8ZuXpslZopHGHzfOojlAnlwUWEX
RFrkF4eHYw4DI34TVfNut3MxekMcWqwLXhzx1cr3msI4KtrMqT2PKNaxDW0cXuO1
OhmseAgrdWqWRV2u6g3Jf7gdjlsrUhSDvqVbwd+zUnZoVk/wUv8=
=3FK+
-----END PGP SIGNATURE-----
diff --git a/debian/control b/debian/control
index fce9de12..c494055d 100644
--- a/debian/control
+++ b/debian/control
@@ -29,6 +29,7 @@ Build-Depends:
libgit-wrapper-perl <!nocheck>,
libgitlab-api-v4-perl (>= 0.13) <!nocheck>,
libipc-run-perl <!nocheck>,
+ libjson-perl <!nocheck>,
liblist-compare-perl <!nocheck>,
libmoo-perl <!nocheck>,
libstring-shellquote-perl <!nocheck>,
diff --git a/debian/tests/control b/debian/tests/control
index eb8095b0..2b09c1de 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -9,6 +9,7 @@ Depends:
libdistro-info-perl,
libgitlab-api-v4-perl,
libipc-run-perl,
+ libjson-perl,
libtest-output-perl,
libwww-perl,
mozilla-devscripts,
diff --git a/test/t/salsa.pm b/test/t/salsa.pm
index 800d1e59..b737e262 100644
--- a/test/t/salsa.pm
+++ b/test/t/salsa.pm
@@ -3,6 +3,7 @@
package MockRESTClient;
use URI;
use Moo;
+ use JSON;
extends 'GitLab::API::v4::RESTClient';
has _mocks => (
