Hi again Jonathan,

On Sat, Jun 24, 2023 at 10:28:07PM +0200, Daniel Gröber wrote:
> > Some notes:
> > 
> > prjtrellis:
> > 
> > - I tried to build it from source (using the tarballs, with
> >   dpkg-buildpackage), but it failed because it can't find
> >   version.cpp. After a dirty hack to ensure that version.cpp is present
> >   and usable, and unpacking the orig-database tarball to the right
> >   location, the package builds for me.
> 
> Did you build with git/gbp or using the dsc? I see that the build system
> tries to extract the version using git commands. However I always test with
> sbuild so my build environment should also have been a plain unpacked dsc
> and not a git repo. Strange.

I see what was going on now. The cmake logic was changing behaviour
depending on if `git` is installed or not. So in my sbuild run it was fine
because it wasn't but if git is available it tries to run it and fails.

I've submitted a fix upstream using the handy git export-subst trick I'm so
fond of and would like to see more projects adopt:
https://github.com/YosysHQ/prjtrellis/pull/227.

> > nextpnr:
> > 
> > - debian/upstream/metadata: Some of the authors have updated names that
> >   should be used instead of the old names. As far as I can gather:
> >    - Myrtle Shah[1] (a.k.a. gatecat)
> >    - Claire Xenia Wolf[2] (a.k.a. Claire Xen)
> 
> This one is tricky. The license asks that the notices in the source be
> preserved, so it's not clear to me we can honor such name changes without
> explicit permission from the respective copyright holder.

I should learn to read, this is just the upstream metadata. Ofc. we can
change the names there :-)

> > - Building multiple times in the same source directory fails,
> >   override_dh_auto_clean needs a "rm -rf
> >   debian/nextpnr-*-qt-chipdb/usr/share/nextpnr/chipdb-*.bin" or
> >   similar.  Or maybe upstream "make clean" needs to be fixed.

That turned out to be a bug in d/rules, it was supposed to install chipdb
files from the non-qt packages only.

> > - Somehow the chipdb files are installed to
> >   /usr/share/nextpnr/chipdb-*.bin directly, while nextpnr expects them
> >   in per-arch subdirectories. As a quick work-around I'm symlinked the
> >   expected subdirectories to .

Fixed, I just got the path wrong. I have to copy these manually as they are
not installed by upstream as they just embed the data into the executables

Thanks,
--Daniel

Reply via email to