Control: tags -1 + patch

On Thu, 15 Jun 2023 at 14:22:30 +0100, Simon McVittie wrote:
> This package has a Build-Depends on SDL version 1.2, which
> is unmaintained upstream. I don't see any sign of a runtime dependency,
> though.
> 
> If the dependency isn't actually necessary, please remove it and close
> this bug.

I've confirmed that the dependency isn't necessary: please see attached
patch, also available as
<https://salsa.debian.org/debian/libopenhmd/-/merge_requests/2>.

I haven't tested the resulting binaries (I don't have any VR hardware),
but diffoscope says they are identical to the result of rebuilding the
current source with the same toolchain.

    smcv
>From 8f285cc042976de0de7af2aaa7ee33683db07455 Mon Sep 17 00:00:00 2001
From: Simon McVittie <[email protected]>
Date: Sun, 25 Jun 2023 11:33:32 +0100
Subject: [PATCH] Remove unnecessary build-dependency on libsdl1.2-dev

The SDL-based examples are not built by default, and anyway they want
SDL 2, not the obsolete SDL 1.2.

Removing this build-dependency reveals a missing build-dependency on
pkgconf or pkg-config (for pkg.m4), without which autoreconf will fail;
so add that instead.

The resulting binary packages when built with the libsdl1.2-dev
build-dependency are identical to those when built with only the pkgconf
build-dependency (checked using diffoscope).

Closes: #1038100
---
 debian/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 8bcf1cb..b508a83 100644
--- a/debian/control
+++ b/debian/control
@@ -6,7 +6,7 @@ Build-Depends: debhelper (>= 11),
                libgl1-mesa-dev | libgl-dev,
                libglew-dev,
                libhidapi-dev,
-               libsdl1.2-dev
+               pkgconf
 Standards-Version: 4.4.0
 Vcs-Browser: https://salsa.debian.org/debian/libopenhmd
 Vcs-Git: https://salsa.debian.org/debian/libopenhmd.git -b master
-- 
2.40.1

Reply via email to