Source: mini-buildd
Version: 2.0.0
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: hostname
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

The hostname is embedded in mini-buildd.8 manpage and mini-buildd.html:

  
https://tests.reproducible-builds.org/debian/rb-pkg/trixie/amd64/diffoscope-results/mini-buildd.html

  /usr/share/doc/mini-buildd/html/_static/man/mini-buildd.html

  
Public·(fully·qualified)·hostname·used·for·all·services.·(default:·ionos11-amd64.debian.net)
  vs.
  
Public·(fully·qualified)·hostname·used·for·all·services.·(default:·i-capture-the-hostname)

The attached patch fixes this by not setting a default for --hostname in
the help output.

I have not tested that this has no unintended side-effects, only that it
builds reproducibly; maybe there is a better way to fix this issue.


This seems somewhat similar to the issue with build paths that was fixed
in 2.1.0 in experimental:

  
https://salsa.debian.org/debian/mini-buildd/-/commit/ff52b7aa1f6b7371b21a4beae822e6dae1fb37f2


According to my local tests, With this patch applied mini-buildd should
build reproducibly on tests.reproducible-builds.org! (presuming the
buildpath patch from experimental is also applied to unstable)


Thanks for maintaining mini-buildd!


live well,
  vagrant
From e0dc5984b7fd5c8f0e6fc608ec210dffa81e1232 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Mon, 26 Jun 2023 12:10:11 -0700
Subject: [PATCH] src/mini-buildd: Do not set default value for --hostname.

The build machine hostname ends up getting embedded in documentation
and manpages.
---
 src/mini-buildd | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mini-buildd b/src/mini-buildd
index c6092b5a..bc318499 100755
--- a/src/mini-buildd
+++ b/src/mini-buildd
@@ -62,7 +62,6 @@ class CLI(cli.CLI):
 
         group_conf.add_argument("-N", "--hostname",
                                 action="store",
-                                default=config.HOSTNAME_FQDN,
                                 help="Public (fully qualified) hostname used for all services.")
 
         group_conf.add_argument("-E", "--http-endpoint", action="store", nargs="+",
-- 
2.39.2

Attachment: signature.asc
Description: PGP signature

Reply via email to