On 2023-06-27, Andre Noll wrote:
> On Tue, Jun 27, 12:57, Vagrant Cascadian wrote:
>
>> The attached two patches (one patching the upstream Makefile, the other
>> patching debian/rules) fix this by passing -n to the gzip calls used to
>> compress changelog.Debian and the various manpages.
>> 
>> According to my local tests, with these two patches applied liblopsub
>> should build reproducibly on tests.reproducible-builds.org once it
>> migrates to debian/trixie! This alone does not resolve all
>> reproducibilitiy issues (e.g. build paths, tested in unstable and
>> experimental).
>
> This issue was addressed already four years ago when Chris Lamb (CC)
> submitted an analogous patch, see below. His patch has been part of the
> master branch since then, although no new version has been released.
>
> I therefore assume that there is nothing to do for me in this
> regard. Please let me know if this is not the case.

Given that this change was accepted in 2019, would you consider
uploading a version with the fixes applied to Debian, either by making a
new upstream version, or applying the patches to an older version?

Otherwise, my other Reproducible Builds team members and I will likely
keep wondering why it is not yet reproducible... possibly spending more
time fixing things apparently already with known fixes!

live well,
  vagrant

> commit 2d0464872cec02b53f5bb5ca2a037cb764641c1f
> Author: Chris Lamb <la...@debian.org>
> Date:   Mon Dec 2 10:44:23 2019 +0100
>
>     Make the build reproducible.
>     
>     Whilst working on the Reproducible Builds effort [0] we noticed that
>     liblopsub could not be built reproducibly.
>     
>     This is because it calls "gzip" manually without the -n
>     flag. This should have been reported by lintian via the
>     package-contains-timestamped-gzip tag.
>     
>       [0] https://reproducible-builds.org/
>
> diff --git a/Makefile b/Makefile
> index d1f89b1..e8fb7c0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -18,7 +18,7 @@ AR := ar
>  GROFF := groff
>  CP := cp
>  INSTALL := install
> -GZIP := gzip -f9
> +GZIP := gzip -fn9
>  ZCAT := zcat
>  
>  DATE_FMT := +%B %Y
> diff --git a/debian/rules b/debian/rules
> index 3ba7a74..3e73eac 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -49,8 +49,8 @@ binary: build
>       $(INST_FILE) debian/copyright $(DEVDOCS_DIR)/copyright
>       $(INST_FILE) debian/changelog $(DOCS_DIR)/changelog.Debian
>       $(INST_FILE) debian/changelog $(DEVDOCS_DIR)/changelog.Debian
> -     gzip -f9 $(DOCS_DIR)/changelog.Debian
> -     gzip -f9 $(DEVDOCS_DIR)/changelog.Debian
> +     gzip -fn9 $(DOCS_DIR)/changelog.Debian
> +     gzip -fn9 $(DEVDOCS_DIR)/changelog.Debian
>       dh_makeshlibs
>       dh_shlibdeps
>       dh_strip

Attachment: signature.asc
Description: PGP signature

Reply via email to