Hi Sébastien, Am Thu, Jul 06, 2023 at 09:13:46PM +0200 schrieb Sébastien Villemot: > > I'm not sure so please explain in more detail. dh-r was designed to put > > the lowest restriction regarding the versions. I remember some > > discussion some time ago that Dirk thought we should put stronger > > restrictions (and he is sometimes adding version restrictions manually > > that are not helpful for backporting). If I will be sure I understand > > your point exactly I can check the code and the relevant discussion. > > (Feel free to file a bug report about this and we can discuss it there > > if you think this makes more sense.) > > It comes from this line: > https://salsa.debian.org/r-pkg-team/dh-r/-/blob/master/dh/R.pm#L272 > > More precisely the “r-base-core (>= $rbase_version)” part, which > imposes an unnecessarily tight restriction on the r-base-core version.
Got it, thanks for the explanation. This restriction existed since the early stage of dh-r development https://salsa.debian.org/r-pkg-team/dh-r/-/commit/22fd80b9#L174 by Gordon Ball (in CC but not really active in R pkg team any more) at 2016-09-04 12:28:57 +0200 . I'm guessing this restriction was obtained from the cdbs helper that existed before the dh support was created by Gordon and he simply took over what existed there. The according line in the initial commit of dh-r is say $svs "R:Depends=r-base-core (>= $rversion), $rapiversion"; which supports my thesis. So I went back in history and found the discussion of bug #704805 where several people were finally able to convince Dirk that r-api is a good idea. In r-base changelog we find: r-base (3.2.0-3) unstable; urgency=low * debian/control: The r-base-core package now 'Provides: r-api-3' which can be used to have r-cran-* depend on a particular API vintage. (Closes: #704805) * debiab/r-cran.mk: Have the build-time API vintage encoded as a Depends (with thanks to Julian Gilbey, Charles Plessy, and others for the patch) * debian/control: Set Standards-Version: to current version -- Dirk Eddelbuettel <e...@debian.org> Mon, 11 May 2015 06:08:12 -0500 which contains the change in /usr/share/R/debian/r-cran.mk @@ -96,7 +98,7 @@ dh_installdirs $(debRdir) ## ## support ${R:Depends} via debian/${package}.substvars - echo "R:Depends=r-base-core (>= ${rversion})" >> debian/$(package).substvars + echo "R:Depends=r-base-core (>= ${rversion}), ${rapiversion}" >> debian/$(package).substvars ## ## call R to install the sources we're looking at ## use this inside xvfb-run if this wrapper is installed between this file from r-base (3.2.0-2) So this seems a historic leftover to me probably since Dirk has the opinion that this version restriction is needed. I'd consider it sensible if you open a bug against dh-r where we can document the change you are suggesting. Kind regards Andreas. -- http://fam-tille.de
