Source: transmission
Version: 4.0.1-1
Severity: serious
Justification: Policy 2.2.1
Hi,
The source package contains:
web/public_html/index.html
web/public_html/transmission-app.js
These files are copied into the binary package as:
/usr/share/transmission/public_html/index.html
/usr/share/transmission/public_html/transmission-app.js
Those files should be built from source with no network connection.
The corresponding lintian overrides are wrong: the files are not generated
during build.
# these are generated from web/src/*
transmission source: source-is-missing [web/public_html/index.html]
transmission source: source-is-missing [web/public_html/transmission-app.js]
The sad way to solve this would be to remove the webui (and I'm a user!).
The better way to solve this would be to build and would begin like the
following
but requires packaging some of the below npm deps. I can help and would
appreciate
some guidance or pointers to good examples of source packages that have solved
this problem.
--- a/debian/control
+++ b/debian/control
@@ -21,7 +21,9 @@ Build-Depends: cmake,
qttools5-dev-tools,
qttools5-dev,
libqt5svg5-dev,
- zlib1g-dev
+ zlib1g-dev,
+ node-webpack,
+ node-mini-css-extract-plugin
Standards-Version: 4.6.2
Rules-Requires-Root: no
Vcs-Browser: https://salsa.debian.org/debian/transmission
diff --git a/debian/rules b/debian/rules
index 09fe4f7d..bfed98c1 100755
--- a/debian/rules
+++ b/debian/rules
@@ -2,12 +2,13 @@
#export DH_VERBOSE=1
export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+export NPM_CONFIG_OFFLINE=true
%:
dh $@
override_dh_auto_configure:
- dh_auto_configure -- -DENABLE_GTK=ON -DENABLE_QT=ON -DENABLE_CLI=ON
-DINSTALL_LIB=OFF -DCMAKE_BUILD_TYPE=RelWithDebInfo
+ dh_auto_configure -- -DENABLE_GTK=ON -DENABLE_QT=ON -DENABLE_CLI=ON
-DINSTALL_LIB=OFF -DREBUILD_WEB=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo
override_dh_auto_test:
@echo "skipping auto test"
Thanks,
Alex
--
transmission.git/web$ npm2deb depends package.json
Dependencies:
NPM Debian
transmission-web (FIX_ME version) None
└─ lodash.isequal (^4.5.0) node-lodash
(4.17.21+dfsg+~cs8.31.198.20210220-9)
Build dependencies:
NPM Debian
@babel/core (^7.20.12) node-babel
(6.26.0+repack-3~bpo10+1) @babel/eslint-parser (^7.19.1)
None
@babel/plugin-proposal-class-properties (^7.18.6) None
@primer/stylelint-config (^12.7.0) None
css-loader (^6.7.3) node-css-loader
(6.7.2+~cs14.0.11-1) css-minimizer-webpack-plugin (^4.2.2)
None
eslint (^8.32.0) None
eslint-plugin-sonarjs (^0.18.0) None
eslint-plugin-unicorn (^45.0.2) None
file-loader (^6.2.0) node-file-loader (6.2.0-3)
mini-css-extract-plugin (^2.7.2)
node-mini-css-extract-plugin (2.4.6+~2.4.0-4)npm-run-all (^4.1.5)
None
prettier (^2.8.3) None
sass (^1.57.1) None
sass-loader (^13.2.0) None
style-loader (^3.3.1) node-style-loader (3.3.1-2)
stylelint (^14.16.1) None
stylelint-config-prettier (^9.0.4) None
stylelint-config-sass-guidelines (^9.0.1) None
stylelint-config-standard (^29.0.0) None
terser-webpack-plugin (^5.3.6) None
webpack (^5.76.0) node-webpack
(5.76.1+dfsg1+~cs17.16.16-1) webpack-bundle-analyzer (^4.7.0)
None
webpack-cli (^4.10.0) None
webpack-dev-server (^4.11.1) None
Warnings occurred:
[warning] prettier: Useless in Debian compilation, see node-jest for an example
-- System Information:
Debian Release: trixie/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 6.1.0-10-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
