Package: zulucrypt
Followup-For: Bug #1037454
User: [email protected]
Usertags: origin-ubuntu mantic ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

The test-suite seems to fail on virt-servers that use sudo to run as
root. For some reason, zuluCrypt reads the SUDO_UID variable and calls
seteuid(SUDO_UID) if it exists - before attemping to open the test luks
file (that was created as root earlier).

I opened an upstream bug report:

https://github.com/mhogomchungu/zuluCrypt/issues/209

Unsetting the SUDO_UID variable helps making the autopkgtest succeeds -
although it does not prevent somebody from manually invoking
$ sudo /usr/bin/zuluCrypt-cli --test on the target system

In Ubuntu, the attached patch was applied to achieve the following:

  * Unset SUDO_UID when running the test suite - to make autopkgtest succeed
    on all virt-servers (LP: #2023614).


Thanks for considering the patch.


-- System Information:
Debian Release: bookworm/sid
  APT prefers lunar-updates
  APT policy: (500, 'lunar-updates'), (500, 'lunar-security'), (500, 'lunar'), 
(100, 'lunar-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.1.0-16-generic (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru zulucrypt-6.2.0/debian/tests/control 
zulucrypt-6.2.0/debian/tests/control
--- zulucrypt-6.2.0/debian/tests/control        2022-09-19 04:02:31.000000000 
+0200
+++ zulucrypt-6.2.0/debian/tests/control        2023-07-25 09:44:49.000000000 
+0200
@@ -1,2 +1,2 @@
-Test-Command: zuluCrypt-cli --test
+Test-Command: env -u SUDO_UID zuluCrypt-cli --test
 Restrictions: allow-stderr,isolation-machine,needs-root

Reply via email to