Hi David, Quoting debian....@spam.lublink.net (2023-08-27 16:04:20) > I wrote and applied the required patch ( see attached ). > > > I built the asterisk package 1:20.4.0~dfsg+~cs6.13.40431414-2 and signed > it successfully. > > I installed the new package on my local machine and tested a lua > dialplan. I connected using chan_sip+baresip, and setup a new lua > context in extensions.lua. I called this context and listened to some > menus. ( I had audio ).
Thanks a lot for the thorough testing! I am now building the package and (unless something surprising happens) will release it within an hour. > Since the patch only affects lua integration, I saw no reason to do > further testing. Agreed. > Since I am a new contributor, I'll need help actually pushing this patch > into Salsa and Debian master. For a change this tiny there is really no need to make a formal patch - simply posting here on the list that you've succesfully tested a build with build-dependency changed from liblua5.2-dev to liblua5.1-dev is fine. > @jonas can you grant me salsa access and/or review my patch and > integrate it into salsa? Please don't use the merge-request feature: I am not comfortable using that, but more importantly I find it better to keep conversation about the packaging in bugreports, not some parts in gitlab. (In addition to concerete discussions about bugs I am happy to have casual conversations as well, at our irc channel that we don't need to keep track of - I just currently have trouble reaching it from matrix). In future, please make simple git commits pushed directly to the branch debian/latest where first line of your commit message is sensible to list in Debian changelog - and please *don't* edit debian/changelog. This approach makes it easier to revert or cherry-pick e.g. for a stable backport, and debian/changelog is easily populated using "gpb dch" just before building the package. Please request membership at https://salsa.debian.org/pkg-voip-team/asterisk/-/project_members to gain write access to the git repo. (I have now disabled the MR feature for this package, which also killed the conversation you started there - I forgot to take note of your account so cannot invite you into the group myself). ...and while writing this the build finished and I have now pushed it to Debian :-) > Also, I ran dput, but got no response from debian masters ( probably > because I am not authorized to build the asterisk package ) . Correct: dput works but the resulting uploaded source package gets silently dropped because a) your OpenPGP signature is not in the list of trusted Debian Developers, and b) because it was uploaded by someone not trusted that someone could have forged a bogus contact address so it won't be contacted to avoid backscatter. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ * Sponsorship: https://ko-fi.com/drjones [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
