Control: reassign -1 vala
Control: found -1 0.56.12-1
Control: affects -1 source:granite-7
Control: retitle -1 vala: Regression: Gtk.CssProvider.load_from_data has 
breaking change of VAPI signature in 0.56.11 / main
Control: forwarded -1 https://gitlab.gnome.org/GNOME/vala/-/issues/1478
Control: tags -1 fixed-upstream patch
X-Debbugs-CC: ric...@ubuntu.com

在 2023-08-27星期日的 22:57 +0200,Aurelien Jarno写道:
> Source: granite-7
> Version: 7.3.0-1
> Severity: serious
> Tags: ftbfs
> Justification: fails to build from source (but built successfully in the past)
> 
> Dear maintainer,
> 
> granite-7 fails to build from source. From my build log on amd64:
> 
> > valac -C --define=LINUX --abi-stability --hide-internal --target-glib=2.50 
> > --pkg posix --pkg gtk4 --pkg gobject-2.0 --target-glib 2.50 --pkg glib-2.0 
> > --pkg gio-unix-2.0 --
> > pkg gio-2.0 --pkg gee-0.8 --color=always --directory 
> > lib/libgranite-7.so.7.3.0.p --basedir ../lib --library granite-7 --header 
> > lib/granite-7.h --vapi ../granite-7.vapi --
> > gir ../Granite-7.0.gir --gresources=../lib/Styles/styles.gresource.xml 
> > ../lib/DateTime.vala ../lib/Constants.vala ../lib/Init.vala 
> > ../lib/Services/Application.vala
> > ../lib/Services/AsyncMutex.vala ../lib/Services/ContractorProxy.vala 
> > ../lib/Services/Portal.vala ../lib/Services/Settings.vala 
> > ../lib/Services/System.vala
> > ../lib/Widgets/AbstractSettingsPage.vala 
> > ../lib/Widgets/AbstractSimpleSettingsPage.vala 
> > ../lib/Widgets/AccelLabel.vala ../lib/Widgets/DatePicker.vala
> > ../lib/Widgets/Dialog.vala ../lib/Widgets/HeaderLabel.vala 
> > ../lib/Widgets/HyperTextView.vala ../lib/Widgets/MessageDialog.vala 
> > ../lib/Widgets/ModeSwitch.vala
> > ../lib/Widgets/OverlayBar.vala ../lib/Widgets/Placeholder.vala 
> > ../lib/Widgets/SettingsSidebarRow.vala ../lib/Widgets/SettingsSidebar.vala 
> > ../lib/Widgets/Settings.vala
> > ../lib/Widgets/SwitchModelButton.vala ../lib/Widgets/TimePicker.vala 
> > ../lib/Widgets/Toast.vala ../lib/Widgets/Utils.vala 
> > ../lib/Widgets/ValidatedEntry.vala lib/Config.vala
> > ../lib/Init.vala:53.9-53.24: warning: `Gtk.StyleContext' has been 
> > deprecated since 4.10
> >    53 |         Gtk.StyleContext.add_provider_for_display (display, 
> > base_provider, Gtk.STYLE_PROVIDER_PRIORITY_THEME);
> >       |         ^~~~~~~~~~~~~~~~                                            
> >                                           
> > ../lib/Init.vala:56.13-56.28: warning: `Gtk.StyleContext' has been 
> > deprecated since 4.10
> >    56 |             Gtk.StyleContext.add_provider_for_display (display, 
> > app_provider, Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION);
> >       |             ^~~~~~~~~~~~~~~~                                        
> >                                                    
> > ../lib/Widgets/AccelLabel.vala:110.43-110.71: warning: 
> > `Gtk.Widget.get_style_context' has been deprecated since 4.10
> >   110 |                 var accel_label_context = 
> > accel_label.get_style_context ();
> >       |                                           
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~    
> > ../lib/Widgets/AccelLabel.vala:110.21-110.39: warning: `Gtk.StyleContext' 
> > has been deprecated since 4.10
> >   110 |                 var accel_label_context = 
> > accel_label.get_style_context ();
> >       |                     ^~~~~~~~~~~~~~~~~~~                             
> >        
> > ../lib/Widgets/HyperTextView.vala:252.9-252.20: warning: `Gtk.show_uri' has 
> > been deprecated since 4.10
> >   252 |         Gtk.show_uri (null, uri, Gdk.CURRENT_TIME);
> >       |         ^~~~~~~~~~~~                               
> > ../lib/Widgets/ModeSwitch.vala:91.9-91.37: warning: 
> > `Gtk.Widget.get_style_context' has been deprecated since 4.10
> >    91 |         mode_switch.get_style_context ().add_class 
> > (Granite.STYLE_CLASS_MODE_SWITCH);
> >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~                               
> >                  
> > ../lib/Widgets/SettingsSidebarRow.vala:83.9-83.37: warning: 
> > `Gtk.Widget.get_style_context' has been deprecated since 4.10
> >    83 |         title_label.get_style_context ().add_class 
> > (Granite.STYLE_CLASS_H3_LABEL);
> >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~                               
> >               
> > ../lib/Widgets/SettingsSidebar.vala:95.17-95.39: warning: 
> > `Gtk.Widget.get_style_context' has been deprecated since 4.10
> >    95 |                 label.get_style_context ().add_class 
> > (Granite.STYLE_CLASS_H4_LABEL);
> >       |                 ^~~~~~~~~~~~~~~~~~~~~~~                             
> >                 
> > ../lib/Widgets/SwitchModelButton.vala:53.49-53.83: warning: 
> > `Gtk.Widget.get_style_context' has been deprecated since 4.10
> >    53 |         unowned var description_style_context = 
> > description_label.get_style_context ();
> >       |                                                 
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~    
> > ../lib/Widgets/SwitchModelButton.vala:53.21-53.45: warning: 
> > `Gtk.StyleContext' has been deprecated since 4.10
> >    53 |         unowned var description_style_context = 
> > description_label.get_style_context ();
> >       |                     ^~~~~~~~~~~~~~~~~~~~~~~~~                       
> >                    
> > ../lib/Widgets/Utils.vala:269.38-269.45: error: Argument 1: Cannot convert 
> > from `unowned uint8[]' to `unowned string'
> >   269 |         css_provider.load_from_data (css.data);
> >       |                                      ^~~~~~~~  
> > ../lib/Widgets/Utils.vala:269.9-269.46: error: 1 missing arguments for 
> > `void Gtk.CssProvider.load_from_data (string, ssize_t)'
> >   269 |         css_provider.load_from_data (css.data);
> >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
> > ../lib/Widgets/Utils.vala:272.9-272.24: warning: `Gtk.StyleContext' has 
> > been deprecated since 4.10
> >   272 |         Gtk.StyleContext.add_provider_for_display 
> > (Gdk.Display.get_default (), css_provider, priority);
> >       |         ^~~~~~~~~~~~~~~~                                            
> >                                    
> > ../lib/Widgets/ValidatedEntry.vala:65.54-65.70: warning: 
> > `Gtk.Widget.get_style_context' has been deprecated since 4.10
> >    65 |             unowned Gtk.StyleContext style_context = 
> > get_style_context ();
> >       |                                                      
> > ^~~~~~~~~~~~~~~~~    
> > ../lib/Widgets/ValidatedEntry.vala:65.38-65.50: warning: `Gtk.StyleContext' 
> > has been deprecated since 4.10
> >    65 |             unowned Gtk.StyleContext style_context = 
> > get_style_context ();
> >       |                                      ^~~~~~~~~~~~~                  
> >       
> > Compilation failed: 2 error(s), 13 warning(s)
> > ninja: build stopped: subcommand failed.
> > dh_auto_build: error: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 ninja -j12 
> > -v returned exit code 1
> > make: *** [debian/rules:12: binary-arch] Error 25
> > dpkg-buildpackage: error: debian/rules binary-arch subprocess returned exit 
> > status 2
> 
> A full build log on riscv64 is also available:
> https://buildd.debian.org/status/package.php?p=granite-7&suite=sid

The behavior of Gtk.CssProvider.load_from_data changed unexpectedly in Vala 
0.56.11. This change will
be reverted in Vala 0.56.13.

To solve the FTBFS bug of src:granite-7, a backported patch on current Vala 
0.56.12-1 is needed, or a rebuild
is needed after Vala 0.56.13 is packaged.

Thanks,
Boyuan Yang

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to