On Thu Aug 31, 2023 at 6:46 PM CEST, Christopher Obbard wrote: > On Thu, 2023-08-31 at 17:50 +0200, Diederik de Haas wrote: > > > To build U-Boot in Debian for these "new" targets we'd need to: > > > 1) build and distribute U-Boot for these "new" targets without the > > > TPL/TF-A > > > > AFAICT, TF-A for *rk356x* is really close to being mergeable? It appears to > > me that all that's needed is to "dot the i's" and > > the right people pushing the right 'buttons' (in the right sequence).
I'm not really familiar with Gerrit, but it appears to me that someone needs to review and if it's OK, give a '+1' for Code-Review. And for the CI to run, someone needs to '+1' for Allow-CI. And possibly similar things for the 'Hashtags'/'Other labels'. That's what I meant by "pushing the right 'buttons' (in the right sequence)". > I'm not entirely sure about that. In any case, for the rk3588 in U-Boot I was talking solely about TF-A for rk3566/rk3568 here; the situation for rk3588 is unknown to me and could be totally different. AFAICT, there are 2 'MRs' for TF-A for rk356x: 1) Addition to the (CI) build config 2) The actual patch set for TF-A for rk356x ad 1) https://review.trustedfirmware.org/c/ci/tf-a-ci-scripts/+/20480 AFAICT the (minor) review comments have been addressed in patchset 2. It may need a fix as identified by '2'. ad 2) https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/16952 Depends on 1 AFAICT. It's missing a SCMI part, but the plan is to add that in a subsequent patch. What I have identified as issues are the following: - needs to be rebased on current `master` - commit title: `s/^:feat:/feat:/` (IOW drop the preceding ':') - includes need to be in a specific order; see https://trustedfirmware-a.readthedocs.io/en/latest/process/coding-style.html#include-statement-ordering - `plat/rockchip/rk3568/drivers/pmu/pmu.c`, `plat/rockchip/rk3568/drivers/soc/soc.c` and `plat/rockchip/rk3568/plat_sip_calls.c` need to be added to `tf-cov-make` (see '1') - Extend commit message wrt changes in `lib/cpus/aarch64/cortex_a55.S` - In `plat/rockchip/rk3568/drivers/pmu/pmu.c`, "Use braces { } even for single line statements" And then trigger the CI again and address any issues that come up. That does not sound like an enormous amount of work to me. If then the right people give their '+1' on the various categories, then it could be merged? Cheers, Diederik
signature.asc
Description: This is a digitally signed message part.
